New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pad_image
filter generating closed surfaces
#6051
Conversation
pad_image
filterpad_image
filter generating closed surfaces
Additional info: This filter simply adds padding to the image. It can used for many applications where padding is needed. One such use, which is a bit of a workaround in this case, is to enable generating closed surfaces as part of #5968. There, the image padding is implicit, i.e. setting |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6051 +/- ##
==========================================
+ Coverage 96.96% 96.97% +0.01%
==========================================
Files 141 141
Lines 24532 24624 +92
==========================================
+ Hits 23788 23880 +92
Misses 744 744 |
@pyvista-bot preview |
@pyvista-bot preview |
@pyvista-bot preview |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Add new ImageDataFilter
pad_image
.PartlyFully resolves #2201Image padding will be used by #5968 to enable generating "closed" surfaces at the edges of images (otherwise regions at the edges are left open by vtkSurfaceNets).
For now the filter only implements constant padding. I'll try addingThewrap
andmirror
but may not if those filters don't behave nicely with the current implementation.wrap
andmirror
options have been added.