Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make example section of PyVista logo effective #6063

Merged
merged 1 commit into from
May 10, 2024

Conversation

tkoyama010
Copy link
Member

@tkoyama010 tkoyama010 commented May 9, 2024

Overview

This is the follow-up PR of #6051.

@user27182 let me split PR to change the docstring of the PyVista logo.

Details

  • None

Co-authored-by: user27182 <89109579+user27182@users.noreply.github.com>
@tkoyama010
Copy link
Member Author

@pyvista-bot preview

@tkoyama010 tkoyama010 enabled auto-merge (squash) May 9, 2024 22:14
@pyvista-bot pyvista-bot added the documentation Anything related to the documentation/website label May 9, 2024
Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.96%. Comparing base (006eb72) to head (be5d292).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6063   +/-   ##
=======================================
  Coverage   96.96%   96.96%           
=======================================
  Files         141      141           
  Lines       24530    24530           
=======================================
  Hits        23786    23786           
  Misses        744      744           

@pyvista-bot
Copy link
Contributor

@tkoyama010
Copy link
Member Author

@pyvista-bot LGTM
image

Copy link
Contributor

@pyvista-bot pyvista-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because tkoyama010 said so in here :shipit:

@tkoyama010 tkoyama010 merged commit 3e9a19d into main May 10, 2024
31 checks passed
@tkoyama010 tkoyama010 deleted the doc/update-logo-design branch May 10, 2024 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Anything related to the documentation/website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants