Fix active normals for properties point_normals, cell_normals, and method plot_normals with smooth_shading
#6062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkoyama010
requested changes
May 9, 2024
Co-authored-by: Tetsuo Koyama <tkoyama010@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6062 +/- ##
==========================================
+ Coverage 96.98% 96.99% +0.01%
==========================================
Files 141 141
Lines 24639 24640 +1
==========================================
+ Hits 23895 23899 +4
+ Misses 744 741 -3 |
|
Note: the So, that test was failing because with this PR, the "stock" normals are now used, resulting in a different rendering. The new rendered image is updated in 2bfc4a1 |
user27182
commented
May 10, 2024
tkoyama010
approved these changes
May 12, 2024
tkoyama010
added
the
breaking-change
tkoyama010
added a commit
that referenced
this pull request
May 14, 2024
…d method `plot_normals` with `smooth_shading` (#6062) * Fix point_normals and cell_normals properties * Add plot_normals test * Add fix for smooth shading * Update test * Update docs * Apply suggestions from code review Co-authored-by: Tetsuo Koyama <tkoyama010@gmail.com> * Update backface param test image --------- Co-authored-by: Tetsuo Koyama <tkoyama010@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6061
Resolves #2921
Resolves #6058