Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for point_normals, cell_normals, face_normals #6069

Merged
merged 1 commit into from
May 10, 2024

Conversation

user27182
Copy link
Contributor

Fix normals in docs which would have changed from the fix in #4674.

This is a follow up to #6062 to make sure that changes from that PR are not the cause of the changes to the sphere's normals.

@pyvista-bot pyvista-bot added the documentation Anything related to the documentation/website label May 10, 2024
Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.96%. Comparing base (5561441) to head (9e11ba4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6069   +/-   ##
=======================================
  Coverage   96.96%   96.96%           
=======================================
  Files         141      141           
  Lines       24532    24532           
=======================================
  Hits        23788    23788           
  Misses        744      744           

@tkoyama010
Copy link
Member

@pyvista-bot preview

@pyvista-bot
Copy link
Contributor

Copy link
Member

@tkoyama010 tkoyama010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# doctest:+SKIP removal confirms this correctness. LGTM

@tkoyama010 tkoyama010 merged commit 06e7a8f into pyvista:main May 10, 2024
28 checks passed
@user27182 user27182 deleted the doc/update_normals branch May 10, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Anything related to the documentation/website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants