Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix active normals for properties point_normals, cell_normals, and method plot_normals with smooth_shading #6062

Merged
merged 10 commits into from
May 13, 2024
Merged

Fix active normals for properties point_normals, cell_normals, and method plot_normals with smooth_shading #6062

merged 10 commits into from
May 13, 2024
+79 −43

Commits on May 9, 2024

  1. Fix point_normals and cell_normals properties

    @user27182
    user27182 committed May 9, 2024
    Configuration menu
    Copy the full SHA
    5d8d023 View commit details
    Browse the repository at this point in the history

  2. Add plot_normals test

    @user27182
    user27182 committed May 9, 2024
    Configuration menu
    Copy the full SHA
    f91b97d View commit details
    Browse the repository at this point in the history

  3. Add fix for smooth shading

    @user27182
    user27182 committed May 9, 2024
    Configuration menu
    Copy the full SHA
    144c14a View commit details
    Browse the repository at this point in the history

  4. Update test

    @user27182
    user27182 committed May 9, 2024
    Configuration menu
    Copy the full SHA
    0bac656 View commit details
    Browse the repository at this point in the history

  5. Update docs

    @user27182
    user27182 committed May 9, 2024
    Configuration menu
    Copy the full SHA
    dfa39d6 View commit details
    Browse the repository at this point in the history

  6. Apply suggestions from code review 

    Co-authored-by: Tetsuo Koyama <tkoyama010@gmail.com>
    @user27182 @tkoyama010
    user27182 and tkoyama010 committed May 9, 2024
    Configuration menu
    Copy the full SHA
    7243366 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Update backface param test image

    @user27182
    user27182 committed May 10, 2024
    Configuration menu
    Copy the full SHA
    2bfc4a1 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fix/active_normals

    @tkoyama010
    tkoyama010 committed May 10, 2024
    Configuration menu
    Copy the full SHA
    e73be7d View commit details
    Browse the repository at this point in the history

Commits on May 11, 2024

  1. Merge branch 'main' into fix/active_normals

    @user27182
    user27182 committed May 11, 2024
    Configuration menu
    Copy the full SHA
    8da9628 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2024

  1. Merge branch 'main' into fix/active_normals

    @tkoyama010
    tkoyama010 committed May 12, 2024
    Configuration menu
    Copy the full SHA
    c61f427 View commit details
    Browse the repository at this point in the history