Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CRI TimeoutError type #124739

Merged
merged 1 commit into from
May 13, 2024
Merged

Remove CRI TimeoutError type #124739

merged 1 commit into from
May 13, 2024

Conversation

saschagrunert
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

The type is a lefover of dockershim and can be replaced by golang native error wrapping.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Refers to #124634

Does this PR introduce a user-facing change?

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

None

@saschagrunert
Remove CRI TimeoutError type
36b7d55 
The type is a lefover of dockershim and can be replaced by golang native
error wrapping.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 8, 2024
@saschagrunert saschagrunert mentioned this pull request May 8, 2024
Merged
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 8, 2024
@saschagrunert
Copy link
Member Author

/retest

@saschagrunert
Copy link
Member Author

@kubernetes/sig-node-pr-reviews PTAL

endocrimes
endocrimes reviewed May 8, 2024
View reviewed changes
Copy link
Member

@endocrimes endocrimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 8, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c6a31d49925a9a8f71bf8225de06eab58520deee

@endocrimes
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 8, 2024
@bart0sh bart0sh added this to Triage in SIG Node PR Triage May 8, 2024
@bart0sh bart0sh moved this from Triage to Needs Approver in SIG Node PR Triage May 8, 2024
@saschagrunert
Copy link
Member Author

@kubernetes/sig-node-pr-reviews PTAL

@matthyx
Copy link
Contributor

matthyx commented May 11, 2024

/priority important-longterm
/lgtm

@k8s-ci-robot k8s-ci-robot added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label May 11, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label May 11, 2024
@saschagrunert
Copy link
Member Author

@Random-Liu @dchen1107 @derekwaynecarr @yujuhong @sjenning @mrunalp @klueska PTAL

@saschagrunert saschagrunert mentioned this pull request May 13, 2024
Merged
@dims
Copy link
Member

dims commented May 13, 2024

this is a code cleanup, no change in logic or public API (that ends up in staging/). happy to land this.

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2024
@k8s-ci-robot k8s-ci-robot merged commit c12f694 into kubernetes:master May 13, 2024
14 checks passed
SIG Node PR Triage automation moved this from Needs Approver to Done May 13, 2024
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone May 13, 2024
@saschagrunert saschagrunert deleted the timeout-error branch May 14, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@endocrimes endocrimes endocrimes left review comments

@SergeyKanzhelev SergeyKanzhelev Awaiting requested review from SergeyKanzhelev

@tallclair tallclair Awaiting requested review from tallclair

Assignees

@dims dims

@endocrimes endocrimes

@matthyx matthyx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Status: Done
SIG Node PR Triage
Done
Milestone
v1.31
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@saschagrunert @k8s-ci-robot @endocrimes @matthyx @dims