Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make remote runtime and image service logging independent #124741

Merged
merged 1 commit into from
May 13, 2024
Merged

Make remote runtime and image service logging independent #124741

merged 1 commit into from
May 13, 2024
+173 −122

Conversation

saschagrunert
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

It's now possible to pass around the *klog.Logger which can also be nil to disable logging at all.

Which issue(s) this PR fixes:

Refers to #124634

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 8, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 8, 2024
@saschagrunert saschagrunert mentioned this pull request May 8, 2024
Merged
@k8s-ci-robot k8s-ci-robot added area/kubelet area/test sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 8, 2024
@saschagrunert
Make remote runtime and image service logging independent
9c71246 
It's now possible to pass around the `*klog.Logger` which can also be
`nil` to disable logging at all.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@saschagrunert saschagrunert changed the title WIP: Make remote runtime and image service logging independent Make remote runtime and image service logging independent May 8, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 8, 2024
@bart0sh bart0sh added this to Triage in SIG Node PR Triage May 8, 2024
@saschagrunert
Copy link
Member Author

@kubernetes/sig-node-pr-reviews PTAL

@matthyx
Copy link
Contributor

matthyx commented May 11, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 11, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1eef26806d9014d497810e025be9033e083fd865

@saschagrunert
Copy link
Member Author

@Random-Liu @dchen1107 @derekwaynecarr @yujuhong @sjenning @mrunalp @klueska PTAL

@dims
Copy link
Member

dims commented May 13, 2024

@saschagrunert does this need to land first? or #124634?

@dims
Copy link
Member

dims commented May 13, 2024

looks like this was triggered by #124634 (comment)

haircommander
haircommander reviewed May 13, 2024
View reviewed changes
pkg/kubelet/cri/remote/remote_image.go
}

// NewRemoteImageService creates a new internalapi.ImageManagerService.
func NewRemoteImageService(endpoint string, connectionTimeout time.Duration, tp trace.TracerProvider) (internalapi.ImageManagerService, error) {
klog.V(3).InfoS("Connecting to image service", "endpoint", endpoint)
func NewRemoteImageService(endpoint string, connectionTimeout time.Duration, tp trace.TracerProvider, logger *klog.Logger) (internalapi.ImageManagerService, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should there be a new endpoint to not break end users? Or are we not worried about external callers to this yet?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now it's not a real API, just when we move it to staging.

@saschagrunert
Copy link
Member Author

@saschagrunert does this need to land first? or #124634?

Yep, in the same way as #124739

@dims
Copy link
Member

dims commented May 13, 2024

Since this is code that will get used by other projects when we publish this to staging and then separate repo, we should let caller decide how to log it. I don't see any change in logic as well.

the noop.NewTracerProvider kinda sneaked in, but that's a good change to have here as part of this PR itself. treating this as code clean up in prep to publish library code in 1.31.

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2024
@k8s-ci-robot k8s-ci-robot merged commit 63e85ca into kubernetes:master May 13, 2024
15 checks passed
SIG Node PR Triage automation moved this from Triage to Done May 13, 2024
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone May 13, 2024
@saschagrunert saschagrunert deleted the remote-runtime-logging branch May 14, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haircommander haircommander haircommander left review comments

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

Assignees

@dims dims

@matthyx matthyx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Node PR Triage
Status: Done
SIG Node PR Triage
Done
Milestone
v1.31
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@saschagrunert @k8s-ci-robot @matthyx @dims @haircommander