Feature Block Update #1396
Open
Feature Block Update #1396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deining
suggested changes
Feb 8, 2023
H20220009
force-pushed
the
feature-block
branch
from
22ef139
to
46406e7
Compare
|
@deining |
deining
suggested changes
Feb 27, 2023
deining
suggested changes
Feb 27, 2023
|
@deining |
deining
suggested changes
Mar 31, 2023
|
@deining |
As the changes were requested, I used With function so that link is applied only when the URL is given
As asked I had written the code so that it will generate valid markup in both cases that is whether the "URL" is included or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made all the necessary changes as asked in feature request #1241.
I hope it resolves that problem.
Please let me know if any other changes are needed.