Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Make the "blocks/feature" url also apply to icon and headline #1241

Open
heinrich-ulbricht opened this issue Sep 24, 2022 · 13 comments

Comments

@heinrich-ulbricht
Copy link

heinrich-ulbricht commented Sep 24, 2022

When adding a feature block one can specify a URL to link to. This will generate a "Read more..." link at the bottom of the feature the user can click.

My proposal is to also link the feature's icon and title to the same destination URL. Personally I often just immediately click the icon to proceed. And this often does not work which is frustrating. And with Docsy this unfortunately also doesn't work.

@heinrich-ulbricht heinrich-ulbricht changed the title Proposal: Make the blocks/feature url also link from icon and headline Proposal: Make the "blocks/feature" url also apply to icon and headline Sep 24, 2022
@H20220009
Copy link

Hi, is this issue still open?
I want to work on this issue; please assign me to this.

@deining
Copy link
Collaborator

deining commented Jan 23, 2023

Hi, is this issue still open?

Yes, I think so.

I want to work on this issue

Go ahead and author and submit a pull request that resolves the issue.

please assign me to this.

Done.

@H20220009
Copy link

@heinrich-ulbricht @deining
Can you please elaborate on this issue?
What exactly and where do I have to make the changes?

@emckean
Copy link
Collaborator

emckean commented Jan 27, 2023

Hi @H20220009, unfortunately we don't have the resources in this project to give this level of direction.

Are you being asked to contribute to an open source project as part of a school assignment? You may want to look for projects that have issues tagged "good first issue", this repo will help you find them: https://github.com/EddieHubCommunity/good-first-issue-finder

This repo is for people who need GitHub contribution practice: https://github.com/firstcontributions/first-contributions

@H20220009
Copy link

Hi, @emckean @deining @chalin
I was busy with some work, hence couldn't reply to your message.
It is not like that I'm being asked to contribute to open source as an academic assignment.
This is because of interest that I choose to work on this issue and I want to continue working on this issue.

@H20220009
Copy link

@emckean @deining @chalin
Can you review the changes and provide any feedback for PR #1396.

@H20220009
Copy link

@emckean @deining @chalin
As asked by @deining in his review on PR #1396, I had made the necessary changes for PR #1396.
Can you please review those changes and provide feedback for the same.

@H20220009
Copy link

@emckean @deining @chalin
As asked by @deining in his second review on PR #1396 , I had made the necessary changes for that PR #1396.
Can you please review those changes and provide feedback for the same.

@H20220009
Copy link

@emckean @deining @chalin
As asked by @deining in his latest review on PR #1396 , I had made the necessary changes for that PR #1396.
Please review those changes and provide feedback for the same.

@H20220009
Copy link

@emckean @deining @chalin
As asked by @deining in his latest review on PR #1396, I had made the necessary changes for that PR #1396.
Can you please take out some time and review those changes.

@H20220009
Copy link

@emckean @chalin @deining
Can you please review the PR #1396, I had made the necessary modification after the last review.

@H20220009
Copy link

@emckean @chalin @deining
Can you please review the PR #1396

@H20220009
Copy link

@emckean @chalin @deining
Can you please review the PR #1396, I had made the necessary modification after the last review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants