Fix accidental name exposure on cross-package import use. #3955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on #3954 |
chandlerc
approved these changes
May 17, 2024
jonmeow
force-pushed
the
fix-cross-package-use
branch
from
921c22d
to
6bf76c4
Compare
jonmeow
force-pushed
the
fix-cross-package-use
branch
from
6bf76c4
to
b469474
Compare
jonmeow
force-pushed
the
fix-cross-package-use
branch
from
b469474
to
0b977c3
Compare
CJ-Johnson
pushed a commit
to CJ-Johnson/carbon-lang
that referenced
this pull request
May 23, 2024
…guage#3955) Looking at `export` handling, I noticed and figured to fix this case first. Also makes the test file prelude-agnostic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at
exporthandling, I noticed and figured to fix this case first.Also makes the test file prelude-agnostic.