Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Directive->Decl in general, BindExport->ExportDecl #3957

Merged
merged 1 commit into from
May 20, 2024
Merged

Rename Directive->Decl in general, BindExport->ExportDecl #3957

merged 1 commit into from
May 20, 2024

Conversation

jonmeow
Copy link
Contributor

@jonmeow jonmeow commented May 17, 2024 •
edited

Mechanically, replacing Directive->Decl, directive->declaration, _declaration->_decl (to avoid comments).

Context: https://discord.com/channels/655572317891461132/963846118964350976/1241145948625703062

@jonmeow
Copy link
Contributor Author

jonmeow commented May 17, 2024 •
edited

Depends on #3955 [ed: now merged]

@github-actions github-actions bot requested a review from zygoloid May 17, 2024 22:22
@chandlerc
Copy link
Contributor

Title says "BindExport -> BindDecl", I think it should be "... -> ExportDecl"

@jonmeow jonmeow changed the title Rename Directive->Decl in general, BindExport->BindDecl Rename Directive->Decl in general, BindExport->ExportDecl May 20, 2024
@jonmeow
Copy link
Contributor Author

jonmeow commented May 20, 2024

Title says "BindExport -> BindDecl", I think it should be "... -> ExportDecl"

Thanks, fixed

@jonmeow jonmeow force-pushed the directive-to-decl branch 2 times, most recently from bcc2ea8 to 485ef3c Compare May 20, 2024 17:36
chandlerc
chandlerc approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@chandlerc chandlerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@chandlerc chandlerc added this pull request to the merge queue May 20, 2024
@jonmeow jonmeow removed this pull request from the merge queue due to a manual request May 20, 2024
@jonmeow jonmeow added this pull request to the merge queue May 20, 2024
Merged via the queue into carbon-language:trunk with commit 03e3a72 May 20, 2024
7 checks passed
@jonmeow jonmeow deleted the directive-to-decl branch May 20, 2024 22:59
CJ-Johnson pushed a commit to CJ-Johnson/carbon-lang that referenced this pull request May 23, 2024
@jonmeow @CJ-Johnson
Rename Directive->Decl in general, BindExport->ExportDecl (carbon-lan…
a9f0c56 
…guage#3957)

Mechanically, replacing Directive->Decl, directive->declaration,
_declaration->_decl (to avoid comments).

Context:
https://discord.com/channels/655572317891461132/963846118964350976/1241145948625703062
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chandlerc chandlerc chandlerc approved these changes

@zygoloid zygoloid Awaiting requested review from zygoloid

Assignees
No one assigned
Labels
toolchain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonmeow @chandlerc