Edit farsi translation and add 'words' #1290
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1,24 @@ | ||
| - id: prev_page | ||
| translation: "صفحه قبل" | ||
|
|
||
| - id: next_page | ||
| translation: "صفحه بعد" | ||
|
|
||
| - id: read_time | ||
| translation: | ||
| one : "1 دقیقه" | ||
| other: "{{ .Count }} دقیقه" | ||
|
|
||
| - id: words | ||
| translation: | ||
| one : "کلمه" | ||
|
There was a problem hiding this comment. Shouldn't this be "۱ کلمه" or "یک کلمه"? There was a problem hiding this comment. If you like, you could use "واژه" as well. |
||
| other: "{{ .Count }} کلمه" | ||
|
|
||
| - id: toc | ||
| translation: "فهرست مطالب" | ||
|
|
||
| - id: translations | ||
| translation: "ترجمهها" | ||
|
There was a problem hiding this comment. I think the correct form would be using half-space. Ref: https://utype.ir/blog/%D9%86%DB%8C%D9%85-%D9%81%D8%A7%D8%B5%D9%84%D9%87-%D9%81%D8%A7%D8%B1%D8%B3%DB%8C/#:~:text=%DB%B5%2D%20%D8%AF%D8%B1%20%D8%B2%D9%85%D8%A7%D9%86,%DA%A9%D8%AA%D8%A7%D8%A8%E2%80%8C%D9%87%D8%A7%D8%8C%20%D8%AE%D8%A7%D9%86%D9%87%E2%80%8C%D9%87%D8%A7 There was a problem hiding this comment. I don't know if you've changed the code or if I was confused before. Anyway, you're doing the right thing now. |
||
|
|
||
| - id: home | ||
| translation: "خانه" | ||
|
|
@@ -25,4 +30,4 @@ | |
| translation: "کپی" | ||
|
|
||
| - id: code_copied | ||
| translation: "کپی شد!" | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why would you want to change this? I think it's better to keep using the Persian numbers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now, it shows Persian numbers just for 1. For others, it shows English numbers. This makes for better compatibility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hialisabet Okay, I didn't notice it. But then I think it'd make sense to change the plural forms to show the Persian numbers.