Edit farsi translation and add 'words' #1290
Conversation
I suggest more comfortable translation for 'prev_page' and 'next_page'. Also, I added farsi translation for missing 'words'.
|
Kudos, SonarCloud Quality Gate passed!
|
|
|
||
| - id: read_time | ||
| translation: | ||
| one: "۱ دقیقه" | ||
| one : "1 دقیقه" |
There was a problem hiding this comment.
Why would you want to change this? I think it's better to keep using the Persian numbers.
There was a problem hiding this comment.
Now, it shows Persian numbers just for 1. For others, it shows English numbers. This makes for better compatibility.
There was a problem hiding this comment.
@hialisabet Okay, I didn't notice it. But then I think it'd make sense to change the plural forms to show the Persian numbers.
| other: "{{ .Count }} دقیقه" | ||
|
|
||
| - id: words | ||
| translation: | ||
| one : "کلمه" |
There was a problem hiding this comment.
Shouldn't this be "۱ کلمه" or "یک کلمه"?
There was a problem hiding this comment.
If you like, you could use "واژه" as well.
| - id: toc | ||
| translation: "فهرست مطالب" | ||
|
|
||
| - id: translations | ||
| translation: "ترجمه ها" | ||
| translation: "ترجمهها" |
There was a problem hiding this comment.
I think the correct form would be using half-space. Ref: https://utype.ir/blog/%D9%86%DB%8C%D9%85-%D9%81%D8%A7%D8%B5%D9%84%D9%87-%D9%81%D8%A7%D8%B1%D8%B3%DB%8C/#:~:text=%DB%B5%2D%20%D8%AF%D8%B1%20%D8%B2%D9%85%D8%A7%D9%86,%DA%A9%D8%AA%D8%A7%D8%A8%E2%80%8C%D9%87%D8%A7%D8%8C%20%D8%AE%D8%A7%D9%86%D9%87%E2%80%8C%D9%87%D8%A7
There was a problem hiding this comment.
I don't know if you've changed the code or if I was confused before. Anyway, you're doing the right thing now.
adityatelange
force-pushed
the
master
branch
from
bcd75b6
to
55b2eb4
Compare
I suggest more comfortable translation for 'prev_page' and 'next_page'. Also, I added farsi translation for missing 'words'.
What does this PR change? What problem does it solve?
There are more comfortable farsi translations for 'prev_page' and 'next_page'. also the translation of 'words' was missing in farsi. because of different directions, It ruins the style of the text!
Was the change discussed in an issue or in the Discussions before?
No, I just noticed and decided to solve it.
PR Checklist