Some minor bug fixes (Senko)

[FunnyShadow]

First of all, thank you very much for making such a beautiful model !

I found that this model didn't work well on Figura 0.1.3+ and it didn't work well with First Person Model and Real Camera mods, after some consulting and learning I fixed both problems and they seem to work perfectly fine now!

Since GitHub can only create PRs for one branch at a time, I've created four PRs

This PR is the first PR to fix some problems with Senko branching.

These PRs might be able to fix some of the problems in the following two Issues (I don't really understand what's wrong with these two Issues due to the language barrier, sorry about that)

• Figura 0.1.3への対応 #13
• Figura 0.1.4への対応 #14

Special thanks to ZhuRuoLing for help on the Lua code!

[Gakuto1112]

Thanks for your pull request! I will review this later. However, I'm busy for another project that has a deadline, so it may takes long time to deal with it. I will do it as soon as possible. Thanks for your corporation!

[Gakuto1112]

With your changes, Figura no longer emits errors. However, your change which fixes the problem with First Person Model and Real Camera doesn't seem to work. Can you fix this?

[Gakuto1112]

In these code, I think that you want to hide the head model in first person perspective with First Person Model or Real Camera. However, these code doesn't seem to work. Even if I checked with only Figura and First Person Model installed. Can you fix this?

[FunnyShadow]

I retried it and it didn't have any problems

[FunnyShadow]

Just a quick question, have you uploaded your model to Figura's servers before?

[FunnyShadow]

If so, you may need to reset your model and re-upload it first, otherwise it will be the old code model that is used

[Gakuto1112]

Just a quick question, have you uploaded your model to Figura's servers before?

I tested the avatar with your changes.
This is tested with the local avatar. (Actually, my global avatar is another one.) I think that this problem doesn't matter if the avatar is local or global.

[Gakuto1112]

I resolved this problem by hiding the head in OTHER context.

events.RENDER:register(function (_, context)
	models.models.main.Avatar.Head:setVisible(context ~= "OTHER")
end)

However, the shadow of the head isn't casted. This doesn't look good...

[FunnyShadow]

hmmmmmm, that's weird, this thing is working fine on my client, please wait, I'll check again

[Gakuto1112]

Which Minecraft version and mod loader (Forge, Fabric, etc.) are you using? Some minor things may be deferent depending on witch Minecraft version and mod loader you are using.

[Gakuto1112]

Another thing that I concerned is that the head of the avatar has gone in preview. Can you show it?

[Gakuto1112]

The head problem seems to be occurred with First Person Model v2.3.4. This is no longer occurred if the mod is downgraded to v2.3.3. This may be the mod's problem...?

[Gakuto1112]

I submitted this issue to First-person Model repository.
tr7zw/FirstPersonModel#431

[FunnyShadow]

Which Minecraft version and mod loader (Forge, Fabric, etc.) are you using? Some minor things may be deferent depending on witch Minecraft version and mod loader you are using.

I'm using the latest version of Fabric (0.15.7), tested on both 1.20.2 and 1.20.4

[FunnyShadow]

Another thing that I concerned is that the head of the avatar has gone in preview. Can you show it?

I can't solve this one either, like the shadow one, because the context doesn't include this interface, so I can't exclude it

[FunnyShadow]

The head problem seems to be occurred with First Person Model v2.3.4. This is no longer occurred if the mod is downgraded to v2.3.3. This may be the mod's problem...?

Looks like it should be ....
I'll submitted this Issue to RealCamera, too.
xTracr/RealCamera#57

[FunnyShadow]

Okay, I've added more context checks based on the developer's tips, and now the rendering in the shadow and Figura GUI should all be working correctly

[FunnyShadow]

I also realized that RealCamera seems to come with some compatibility options and perspective shifting, so maybe this could be a direct solution to the head model rendering errors?

[FunnyShadow]

More context checking has been added, which should fix all the rendering issues this time around

[Gakuto1112]

Okay. I will review your changes tomorrow. Good night.

[Gakuto1112]

This is the result of your code that you want me to try.

[lua] Vinny_san: Context:  OTHER  
[lua] Vinny_san : FirstPerson:  true  
[lua] Vinny_san : Head Visible  true  
[lua] Vinny_san : Context:  FIRST_PERSON  
[lua] Vinny_san : FirstPerson:  true  
[lua] Vinny_san : Head Visible  false  
[lua] Vinny_san : Context:  PAPERDOLL  
[lua] Vinny_san : FirstPerson:  true  
[lua] Vinny_san : Head Visible  true  
[lua] Vinny_san : Context:  OTHER  
[lua] Vinny_san : FirstPerson:  true  
[lua] Vinny_san : Head Visible  true  
[lua] Vinny_san : Context:  FIRST_PERSON  
[lua] Vinny_san : FirstPerson:  true  
[lua] Vinny_san : Head Visible  false  
[lua] Vinny_san : Context:  PAPERDOLL  
[lua] Vinny_san : FirstPerson:  true  
[lua] Vinny_san : Head Visible  true  

According this, the head of the avatar is hidden in FIRST_PERSON context. However, the head in first person perspective is controlled in OTHER context, so can you try if you can hide the head in OTHER context?

However, this causes another problem. As I said, the shadow of the head isn't shown if the head is hidden in OTHER_CONTEXT. Another solution is make the avatar transparent instead of hiding it, but in this case, some translucent objects like water and colored glass, aren't shown if the camera and the head are overlapped.

According to the case that this problem is no longer occurred in First-person Model 2.3.3 or older, it may be caused by dependent mods. Waiting until it is fixed might be one of solutions.

[FunnyShadow]

uhhhh, what other Mods did you use?
The first person avatar rendering actually relies on FIRST_PERSON to control it, and that log showing three actually means everything in the current context, because Figura doesn't seem to support expanding an array all at once, so it outputs them sequentially instead of in a single line.

[FunnyShadow]

The reason I excluded OTHER from the list is because some other mods are influenced by it, such as the paperdoll feature in the Bedrockify mod.

[FunnyShadow]

Normally, context ~= "FIRST_PERSON" and (not renderer:isFirstPerson()) should rule out other first person perspectives altogether, and I added renderer:isFirstPerson() here mainly because I realized that the RealCamera mod doesn't detect standard first person when rendering in first person, so it doesn't provide a FIRST_PERSON context.

[FunnyShadow]

As for the shadow issue, theoretically the context == "FIRST_PERSON_WORLD" and context == "WORLD" rules should take the shadow rendering part out of the equation, but due to my computer's performance I can't use shader packs to render out the shadows so I can't actually test it

Here are the names of all the contexts that can be used to recognize renderer patterns:
https://applejuiceyy.github.io/figs/latest/RenderModes/

[FunnyShadow]

But now that it's fixed, I'll just revert that part of the commit? The author of the issue I submitted with RealCamera also gave me a solution to this problem.

[Gakuto1112]

uhhhh, what other Mods did you use?
The first person avatar rendering actually relies on FIRST_PERSON to control it, and that log showing three actually means everything in the current context, because Figura doesn't seem to support expanding an array all at once, so it outputs them sequentially instead of in a single line.

I tested it again with the following environment:

Item	Version
Minecraft	1.21.4
Fabric Loader	0.96.4+1.20.4
Figura	0.1.4+1.20.4
First-person Model	2.3.4

No other mods are used for testing. However, the issue is still confirmed.

[Gakuto1112]

But now that it's fixed, I'll just revert that part of the commit? The author of the issue I submitted with RealCamera also gave me a solution to this problem.

Is the issue fixed? I still have confirmed the issue with First-person Model.

[FunnyShadow]

hmmmmm, no fix?...Then maybe I misunderstood ()

[Gakuto1112]

There may be a discrepancy in our perceptions. The issue that we're discussing is the issue that the head of the avatar is visible in first person perspective with some mods that modifies behaviors in first person perspective, like First-person model and Real Camera. The expected behavior is that the head of the avatar should be hidden in first person perspective.

Is my thought correct?

[FunnyShadow]

There may be a discrepancy in our perceptions. The issue that we're discussing is the issue that the head of the avatar is visible in first person perspective with some mods that modifies behaviors in first person perspective, like First-person model and Real Camera. The expected behavior is that the head of the avatar should be hidden in first person perspective.

Is my thought correct?

yep