Some minor bug fixes (Suzu) #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! I will review this later. However, I'm busy for another project that has a deadline, so it may takes long time to deal with it. I will do it as soon as possible. Some codes in Suzu are same as Senko's codes. I will resolve this pull request by merging Senko's codes if I can do it. Thanks for your corporation! |
Gakuto1112
requested changes
Mar 4, 2024
There was a problem hiding this comment.
With your changes, Figura no longer emits errors. However, the same problem that I mentioned in #15 is occurred. Can you fix this?
| end | ||
| models.models.main.Avatar.Head:setVisible(shouldRenderHead) | ||
| end) | ||
|
|
There was a problem hiding this comment.
The same problem that I mentioned in #15 is occurred. Can you fix this?
Gakuto1112
requested changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Introduction: #15
This PR is the last PR to fix some problems with
Suzubranching.