add to_ascii(string) function #353
Conversation
marekklis
force-pushed
the
to_ascii
branch
3 times, most recently
from
79bbff6
to
53b6a51
Compare
There was a problem hiding this comment.
Thanks @marekklis, looking good! Just need a test for the happy path and a bit of tidy up of the failure case test you've already got there.
| @@ -153,6 +153,21 @@ object FunctionDefSpec extends PostgresRunnableSpec with ShopSchema { | |||
| r <- testResult.runCollect | |||
| } yield assert(r.head)(equalTo(expected)) | |||
|
|
|||
| assertion.mapErrorCause(cause => Cause.stackless(cause.untraced)) | |||
| }, | |||
| testM("to_ascii") { | |||
There was a problem hiding this comment.
Can you make this into a suite and add a test for both failure and success cases? e.g. ToAscii("Hello") should work but this isn't tested at the moment.
There was a problem hiding this comment.
I can't write a success case test because our test DB default encoding is UTF-8 but to_ascii("hello") fails with the following error:
org.postgresql.util.PSQLException: ERROR: encoding conversion from UTF8 to ASCII not supported
From postgresql docs:
Conversion is only supported from LATIN1, LATIN2, LATIN9, and WIN1250 encodings
There was a problem hiding this comment.
Right, sorry I misread your original comment. I'll add this to another existing issue so we can get you a shiny new container with the right encoding for this test, but this will do for now.
|
|
||
| val testResult = execute(query).to[String, String](identity) | ||
|
|
||
| val assertion = testResult.runCollect.fold( |
There was a problem hiding this comment.
you should be able to use fails instead of fold to get rid of assert(true)(isFalse)
something like:
val assertion = assert(testResult.runCollect.mapError(_.getMessage))(fails(equalTo("ERROR: encoding conversion from UTF8 to ASCII not supported")))there are good examples of this in the main zio repository tests
|
@robmwalsh Thanks for your review. I'll address your feedback shortly |
#201