Add forEachCollectSome
#1160
Open
Add forEachCollectSome
#1160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| val builder = bf.newBuilder(in) | ||
|
|
||
| lazy val recurse: Option[B] => ZPure[W, S, S, R, E, Collection[B]] = { b => | ||
| b.fold(builder)(builder += _) |
There was a problem hiding this comment.
Isn't .forEach clearer here?
There was a problem hiding this comment.
makes sense. I changed those
6809853 (#1160)
sideeffffect
approved these changes
Jul 11, 2023
|
We already have |
|
yeah but can't it only be used with the same effect? |
|
Hello @0pg , are you still interested in getting this merged? Could you please resolve the git conflict? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, Here comes foreach filter again 馃槄
Added infix syntax
forEachCollectSomeofcollectafterforEach(and there is one more for Iterable optimized, this is why the new syntax added instead of using composition of
collectafterforEachon demand)