Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Comprehensive documentation for ZIO HTTP #2838

Open
wants to merge 39 commits into
base: main
Choose a base branch
from

Conversation

varshith257
Copy link

@varshith257 varshith257 commented May 12, 2024

Note

sidebar.js will be updated soon with added new files

varshith257 and others added 3 commits May 12, 2024 09:48
Signed-off-by: M-Vamshi <21211a05f1@bvrit.ac.in>
Signed-off-by: M-Vamshi <21211a05f1@bvrit.ac.in>
@varshith257
Copy link
Author

varshith257 commented May 12, 2024

@khajavi @987Nabil PTAL. I am ready to commit my time for the next 4-5 days to work on this issue completely.

I am adding commits one by one completely to ease the review section-wise. Your review and suggestions could be valuable for adding comprehensive documentation to our zio-http docs website

@varshith257
Copy link
Author

varshith257 commented May 12, 2024

@jdegoes @khajavi @guizmaii @987Nabil Can you review this at your free time?

@varshith257 varshith257 marked this pull request as ready for review May 13, 2024 10:44
@khajavi
Copy link
Member

khajavi commented May 13, 2024

Hello @varshith257
Thanks for your contribution!
I took a look at your work! I think we need to clarify some terms.
So before moving forward, let's see how I think about different sections of the documentation project (in this case ZIO HTTP).

Index - This section serves as a brief introduction to the project, showcasing its capabilities through only one or two simplest examples.

Concept - The Concept section delves into the foundational principles, terminologies, ideas, and methodologies. It should provide users with an understanding of the core domain or the fundamental concepts related to the problem being addressed. We don't need to provide working examples there! It should also give users an overview of the solution in general terms, helping them grasp the key ideas before delving into more detailed information.

Overview - As the initial practical encounter for users after familiarizing themselves with the concepts, the overview section provides compilable code snippets. These snippets demonstrate the implementation of concepts in real-world scenarios, offering users insight into how to utilize ZIO‌ HTTP effectively. Additionally, this section may include showcases to exemplify the range of functionalities achievable with the library.

Reference - This section delves deeper into the API reference, offering comprehensive documentation for users seeking detailed information on specific functionalities and methods within the library.

@varshith257
Copy link
Author

varshith257 commented May 13, 2024

Sure! Same this are in my mind too. I am bit confused about client configuration. First I have updated with basic code like a basic pseudo code of it for better understanding but checks are constantly failing. So I changed again to the examples its compiling.

I have done with almost every sections mentioned in the issue but waiting first get reviewed concepts and tutorial sections and make ease for review as well as to craft a comprehensive documentation for them and then let's go with other.

I want to complete this long awaiting issue before May 17 exactly a year back the issue created 😅

Looking forward for your review and suggestions :)

@khajavi
Copy link
Member

khajavi commented May 13, 2024

@varshith257
I think we are not on the same page, as I see kinds of stuff that are mostly practical stuffs instead of core concepts.
We only need to cover terms and concepts, at best with "no" examples to demonstrate general concepts for each page in this section (or at most with one example for each page).
What you have done until now is somehow similar to a practical overview.

@varshith257
Copy link
Author

What you have done until now is somehow similar to a practical overview.

Can you review and provide suggestions where to improve and needed changes?
So that it wil get me quickly make changes as what's on your mind :)

@varshith257
Copy link
Author

varshith257 commented May 13, 2024

We only need to cover terms and concepts, at best with "no" examples to demonstrate general concepts for each page in this section (or at most with one example for each page).

Okay will remove the examples and explain concepts with no examples. If needed I will least provide pseudocode for demonstration of concept.

I think we can provide one example in the last of each concept discussed in the page.

@varshith257
Copy link
Author

varshith257 commented May 16, 2024

@varshith257 I think we are not on the same page, as I see kinds of stuff that are mostly practical stuffs instead of core concepts. We only need to cover terms and concepts, at best with "no" examples to demonstrate general concepts for each page in this section (or at most with one example for each page). What you have done until now is somehow similar to a practical overview.

@khajavi Modified concepts with your suggestions and thanks for the review. PTAL

Meanwhile I will start working on adding How to guides

@codecov-commenter
Copy link

codecov-commenter commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.61%. Comparing base (3310828) to head (14a3a3f).
Report is 3 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2838      +/-   ##
==========================================
- Coverage   64.64%   64.61%   -0.04%     
==========================================
  Files         156      156              
  Lines        9113     9122       +9     
  Branches     1584     1596      +12     
==========================================
+ Hits         5891     5894       +3     
- Misses       3222     3228       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@varshith257
Copy link
Author

I think concepts and tutorial sections are ready for your final review. Please take a look

@varshith257
Copy link
Author

@jdegoes @khajavi I have also added the list of topics of how-to-guides based on http4k docs as mentioned in the issue. Waiting for the reviews

@varshith257
Copy link
Author

@jdegoes Any luck on this for getting reviewed? I am ready to push other sections too which are in my local machine once this sections are get reviewed.

@sullivan- sullivan- mentioned this pull request Jun 6, 2024
@varshith257
Copy link
Author

@jdegoes Have look at it and review the changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Roll out comprehensive documentation for ZIO HTTP
3 participants