#2653 network-connection-timeout-problem-solved #2676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zio#2653 Here's what has been added or modified: New Method 'retryRequest': Added a new method 'retryRequest' to handle retry logic after a temporary network failure. This method retries the request a specified number of times ('retries' parameter) if it encounters a 'java.net.ConnectException.' Integration of 'retryRequest' Method: Integrated the 'retryRequest' method into the 'NettyClientDriver' class. /claim 2653
TheVixhal
requested review from
jdegoes,
vigoo,
adamgfraser and
987Nabil
as code owners
|
|
I replaced ZIO.effectSuspend with ZIO.suspend. I provided explicit Trace parameters where required. I fixed the type mismatch issue by ensuring that the block inside ZIO.suspend returns a ZIO value. I introduced the new method retryRequest and made the necessary adjustments.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2676 +/- ##
=======================================
Coverage 64.55% 64.55%
=======================================
Files 145 145
Lines 8607 8607
Branches 1521 1521
=======================================
Hits 5556 5556
Misses 3051 3051 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2653
Here's what has been added or modified:
New Method 'retryRequest': Added a new method 'retryRequest' to handle retry logic after a temporary network failure. This method retries the request a specified number of times ('retries' parameter) if it encounters a 'java.net.ConnectException.'
Integration of 'retryRequest' Method: Integrated the 'retryRequest' method into the 'NettyClientDriver' class.
/claim #2653