-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmake/llvm: Don't unset LLVM_CONFIG_EXE #19971
cmake/llvm: Don't unset LLVM_CONFIG_EXE #19971
Conversation
I think it'd be better to let |
You can add -DCMAKE_PREFIX_PATH="${where_is_llvm_bin_and_libraries", but I too don't know why we unset it.
It's already can be overwritten. |
Is it for Exherbo's |
Yes, please. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it is not obvious why to unset, and there is no comment explaining why, it can be removed, and if it needs to be added back then it should come with a comment explaining why.
I found out why: At least on my machine, cmake hangs without this when the right LLVM version is not found. |
In my understanding, to answer what the
Unsetting the variable seems critical on the paths that |
OK let's have it back with a comment explaining its purpose then please |
Reverted in 793f820 |
Left a comment in #12136, asking why we decided to unset
LLVM_CONFIG_EXE
.