Proposal: support multiple signaturePublickeys #229
+23
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow authentication servers to specify an array of profile property public keys instead of just one. Adds a new field, `signaturePublickeys`, to the authlib-injector metadata route at the root of the API. `signaturePublickeys` is an array of strings containing public keys in the same format as the `signaturePublickey`. Any of the keys specified either in `signaturePublickeys` or as the `signaturePublickey` can be used to verify the signature of a textures payload. With this change, authentication server A can forward a texture payload from authentication server B, and the client could accept a texture signed by either authentication server.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows authentication servers to specify an array of profile property public keys instead of just one.
I propose adding a new field,
signaturePublickeys, to the authlib-injector metadata route at the root of the API.signaturePublickeysis an array of strings containing public keys in the same format as thesignaturePublickey. Any of the keys specified either insignaturePublickeysor as thesignaturePublickeycan be used to verify the signature of a textures payload. Authentication servers aren't required to use the new field;signaturePublicKeysis simply ignored if it's missing from the metadata response.With this change, authentication server A could forward a texture payload from authentication server B, and the client could accept a texture signed by either authentication server. Currently, this forwarding only works with Mojang as authentication server B, since Mojang's public key is hardcoded (
mojang-publickey.der).Wiki updates would be needed following this PR.