New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix summary API endpoint returning truncated JSON #3407
Open
hingev
wants to merge
1
commit into
xmrig:master
Choose a base branch
from
hingev:master
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upon startup, until statistics for all intervals were available, the http response for the `summary` endpoint would be corrupted.
I unable to reproduce this, also hashrate values handled by |
This is happening for me too (6.21.2), on 2 different machines. See output here: {
"id": "2a71d747672e9862",
"worker_id": "aorus",
"uptime": 10,
"restricted": true,
"resources": {
"memory": {
"free": 111335350272,
"total": 134157017088,
"resident_set_memory": 9293824
},
"load_average": [5.16, 1.18, 0.46],
"hardware_concurrency": 32
},
"features": ["api", "asm", "http", "hwloc", "tls"],
"results": {
"diff_current": 50000,
"shares_good": 1,
"shares_total": 1,
"avg_time": 10,
"avg_time_ms": 10622,
"hashes_total": 50000,
"best": [1046478, 0, 0, 0, 0, 0, 0, 0, 0, 0],
"error_log": []
},
"algo": "rx/0",
"connection": {
"pool": "pool.supportxmr.com:3333",
"ip": "141.94.96.71",
"uptime": 10,
"uptime_ms": 10622,
"ping": 40,
"failures": 0,
"tls": null,
"tls-fingerprint": null,
"algo": "rx/0",
"diff": 50000,
"accepted": 1,
"rejected": 0,
"avg_time": 10,
"avg_time_ms": 10622,
"hashes_total": 50000,
"error_log": []
},
"version": "6.21.2",
"kind": "miner",
"ua": "XMRig/6.21.2 (Linux x86_64) libuv/1.48.0 gcc/13.2.1",
"cpu": {
"brand": "AMD Ryzen 9 7950X 16-Core Processor",
"family": 25,
"model": 97,
"stepping": 2,
"proc_info": 10882834,
"aes": true,
"avx2": true,
"x64": true,
"64_bit": true,
"l2": 16777216,
"l3": 67108864,
"cores": 16,
"threads": 32,
"packages": 1,
"nodes": 1,
"backend": "hwloc/2.10.0",
"msr": "ryzen_19h_zen4",
"assembly": "ryzen",
"arch": "x86_64",
"flags": ["aes", "vaes", "avx", "avx2", "avx512f", "bmi2", "osxsave", "pdpe1gb", "sse2", "ssse3", "sse4.1", "popcnt", "cat_l3"]
},
"donate_level": 1,
"paused": false,
"algorithms": ["cn/1", "cn/2", "cn/r", "cn/fast", "cn/half", "cn/xao", "cn/rto", "cn/rwz", "cn/zls", "cn/double", "cn/ccx", "cn-lite/1", "cn-heavy/0", "cn-heavy/tube", "cn-heavy/xhv", "cn-pico", "cn-pico/tlo", "cn/upx2", "rx/0", "rx/wow", "rx/arq", "rx/graft", "rx/sfx", "rx/keva", "argon2/chukwa", "argon2/chukwav2", "argon2/ninja", "ghostrider"],
"hashrate": {
"total": [null, null, null],
"highest": null,
"threads": [
[ {
"id": "592e1a54621dcbf3",
"worker_id": "ubuntu-desktop",
"uptime": 179,
"restricted": true,
"resources": {
"memory": {
"free": 92244426752,
"total": 134977318912,
"resident_set_memory": 8257536
},
"load_average": [30.06, 17.91, 9.3],
"hardware_concurrency": 24
},
"features": ["api", "asm", "http", "hwloc", "tls"],
"results": {
"diff_current": 488009,
"shares_good": 8,
"shares_total": 8,
"avg_time": 22,
"avg_time_ms": 22440,
"hashes_total": 2418380,
"best": [37554281, 2780415, 1877196, 899408, 499904, 154811, 138667, 53394, 0, 0],
"error_log": []
},
"algo": "rx/0",
"connection": {
"pool": "pool.supportxmr.com:3333",
"ip": "141.94.96.71",
"uptime": 179,
"uptime_ms": 179521,
"ping": 41,
"failures": 0,
"tls": null,
"tls-fingerprint": null,
"algo": "rx/0",
"diff": 488009,
"accepted": 8,
"rejected": 0,
"avg_time": 22,
"avg_time_ms": 22440,
"hashes_total": 2418380,
"error_log": []
},
"version": "6.21.2",
"kind": "miner",
"ua": "XMRig/6.21.2 (Linux x86_64) libuv/1.48.0 gcc/13.2.1",
"cpu": {
"brand": "AMD Ryzen 9 5900X 12-Core Processor",
"family": 25,
"model": 33,
"stepping": 0,
"proc_info": 10620688,
"aes": true,
"avx2": true,
"x64": true,
"64_bit": true,
"l2": 6291456,
"l3": 67108864,
"cores": 12,
"threads": 24,
"packages": 1,
"nodes": 1,
"backend": "hwloc/2.10.0",
"msr": "ryzen_19h",
"assembly": "ryzen",
"arch": "x86_64",
"flags": ["aes", "vaes", "avx", "avx2", "bmi2", "osxsave", "pdpe1gb", "sse2", "ssse3", "sse4.1", "popcnt", "cat_l3"]
},
"donate_level": 1,
"paused": false,
"algorithms": ["cn/1", "cn/2", "cn/r", "cn/fast", "cn/half", "cn/xao", "cn/rto", "cn/rwz", "cn/zls", "cn/double", "cn/ccx", "cn-lite/1", "cn-heavy/0", "cn-heavy/tube", "cn-heavy/xhv", "cn-pico", "cn-pico/tlo", "cn/upx2", "rx/0", "rx/wow", "rx/arq", "rx/graft", "rx/sfx", "rx/keva", "argon2/chukwa", "argon2/chukwav2", "argon2/ninja", "ghostrider"],
"hashrate": {
"total": [10107.58, 10262.36, null],
"highest": 10893.08,
"threads": [
[415.6, 430.39, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon startup, until hashrate statistics for all intervals were available, the http response for the
summary
endpoint would be corrupted.This was previously mentioned in #290 and #3363
With this fix, it should instead return