Make AMD assembly completely optional through WITH_ASM_AMD (default ON) #3138
+109
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spudz76
force-pushed
the
dev-addOptionalAMD
branch
from
3676203
to
7457c49
Compare
All these changes to support 0.01% of the user base, not a fair trade I think. |
|
If it was bigger %, what I would do is find asm functions that don't compile, move them to a separate .s file and just remove them from the build in CMakeLists.txt for these systems, not touching any .h/.cpp files. |
|
Also, the error in #3136 (comment) has nothing to do with AMD or AMD Zen assembler code specifically, it's just a |
|
IDK, just helping the user. Who knows why Apple assembler doesn't like that instruction which only appears in the ryzen CN code. |
Spudz76
force-pushed
the
dev-addOptionalAMD
branch
2 times, most recently
from
44b71a9
to
cc0d871
Compare
Spudz76
force-pushed
the
dev-addOptionalAMD
branch
from
cc0d871
to
4ba836c
Compare
Spudz76
force-pushed
the
dev-addOptionalAMD
branch
from
4ba836c
to
66030f1
Compare
Spudz76
force-pushed
the
dev-addOptionalAMD
branch
from
66030f1
to
54ac7f1
Compare
Spudz76
force-pushed
the
dev-addOptionalAMD
branch
from
54ac7f1
to
98fba15
Compare
Spudz76
force-pushed
the
dev-addOptionalAMD
branch
2 times, most recently
from
f74127e
to
d51b01e
Compare
Spudz76
force-pushed
the
dev-addOptionalAMD
branch
from
d51b01e
to
a776ebf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Older Apple assembler doesn't understand some AMD opcodes, this allows completely disabling AMD assembly (ryzen/bulldozer) since Apple hardware would never have an AMD anyway. Only works with UNIX-like platforms, ignored on MSVC (not a problem there anyway).
Also makes the AMD MSRs optional as well (separate configurable
WITH_MSR_ZEN) for a fully Intel-only executable.Related to #3136