Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update rclone and dependencies version. #217

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

feilongfl
Copy link

@feilongfl feilongfl commented May 30, 2022

update rclone to 1.58.1
and some dependencies version.

update targetSdkVersion to 31

@CLAassistant
Copy link

CLAassistant commented May 30, 2022

CLA assistant check
All committers have signed the CLA.

@feilongfl feilongfl changed the title update rclone version and dependence version. update rclone version and dependencies version. May 30, 2022
@feilongfl feilongfl changed the title update rclone version and dependencies version. update rclone and dependencies version. May 30, 2022
@ghost
Copy link

ghost commented Jun 2, 2022

I tried that and it make the app crash after app restart when using the black theme

edit, i had trouble to get remotes in documentui, it turn out that the master branch is missing this commit a936ac7

@feilongfl
Copy link
Author

feilongfl commented Jun 2, 2022

I tried that and it make the app crash after app restart when using the black theme

I find this problem is caused by update targetsdkversion.
But after a day of trying and searching, I was not able to resolve this issue which is causing the crash (Error inflating class com.google.android.material.navigation.NavigationView)
I find a simlar problem in stackoverflow, but unfortunately I can't solve the problem I have.

So I choose to delete the commit about upgrade the android version.
Now this PR only upgrades the go/RCLONE/gradle/ndk version

@newhinton
Copy link

Hey @feilongfl, can i use your PR in my fork?
extRact

@feilongfl
Copy link
Author

Hey @feilongfl, can i use your PR in my fork? extRact

Of course you can

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants