chore(lint): enable no-floating-promises rule #11089
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR enables the eslint
no-floating-promises
rule.I noticed that #10991 fixed a bug from a missing
await
statement. Bugs caused by missingawait
statements can be very hard to track down! So, I find that this eslint rule is very helpful in identifying subtle bugs.Current Failures
This PR is currently work-in-progress. I didn't want to spend the time fixing issues if the team doesn't want to enable this rule for some other reason. For your convenience, here's a list of the current failures:
Does it seem worth fixing these issues and enabling the rule? cc @matthewp who reviewed #10991.
Testing
Docs