Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #9188 #9189

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fixes #9188 #9189

wants to merge 4 commits into from

Conversation

at88mph
Copy link
Contributor

@at88mph at88mph commented Oct 3, 2021

What does this pull request (PR) do? / Que fait cette demande « pull » (PR)?

This PR will add a feature to the wb-postback JSON API that will allow a form to set the desired method to be used when submitting the form via AJAX. This is useful when a PUT request is desired, for example. The setup script was also cleaned up, and, I believe, corrected. The sudo command was being used when the root user was being used, but should be the other way around, I believe.

Additional information (optional) / Information additionnelle (optionel)

General checklist / Liste de contrôle générale
Make your own list for the purpose of your Pull request. /// Faites votre propre liste en fonction des besoins de votre demande « pull ».

  • Create/update documentation /// Créer/mettre à jour la documentation
    • Could not find instructions for updating documented API.
  • [ X ] Build and test PR's code /// Rouler le script de compilation et tester le code de la PR
  • Validate changes against WCAG for accessibility /// Valider les changements avec WCAG pour l'accessibilité
  • Ensure documentation is bilingual /// S'assurer que la documentation soit bilingue

Related issues / Requêtes associées
Closes #9188

@duboisp
Copy link
Member

duboisp commented Oct 6, 2021

See my comments here: #9188 (comment)

In short, I am looking for the rational of using a different method when the form is submitted via Ajax vs when the form is submitted in basic HTML mode, which fallback on the HTML form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add method parameter to wb-postback to allow all REST methods
2 participants