Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support deploy command #5752

Merged
merged 15 commits into from
May 27, 2024
Merged

Conversation

yimingjfe
Copy link
Member

Summary

Related Links

Checklist

  • I have added changeset via pnpm run change.
  • I have updated the documentation.
  • I have added tests to cover my changes.

Copy link

changeset-bot bot commented May 16, 2024

🦋 Changeset detected

Latest commit: 7db7ee4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 261 packages
Name Type
@modern-js/app-tools Minor
@modern-js/server-core Minor
@modern-js/plugin-bff Minor
@modern-js/plugin-ssg Minor
@modern-js/plugin-swc Minor
@modern-js/plugin-tailwindcss Minor
@modern-js/devtools-client Minor
@modern-js/devtools-kit Minor
@modern-js/plugin-devtools Minor
@modern-js/plugin-garfish Minor
@modern-js/plugin-router-v5 Minor
@modern-js/runtime Minor
@modern-js/plugin-express Minor
@modern-js/plugin-koa Minor
@modern-js/plugin-polyfill Minor
@modern-js/plugin-server Minor
@modern-js/plugin-worker Minor
tests Minor
@integration-test/alias-set Minor
api-service-koa Minor
app-docmuent Minor
integration-asset-prefix Minor
async-entry-test Minor
tmp Minor
bff-express Minor
bff-koa Minor
integration-builder-plugins Minor
integration-clean-dist-path Minor
integration-compatibility Minor
integration-copy-assets Minor
integration-custom-dist-path Minor
integration-custom-render Minor
integration-custom-template Minor
deploy Minor
deploy-server Minor
dev-server Minor
@integration-test/devtools Minor
integration-disable-html Minor
esbuild-transform-and-minify Minor
integration-config-async-config-test Minor
integration-basic-local-config Minor
integration-config-function-params Minor
integration-local-config-function Minor
main-entry-name Minor
nonce Minor
routes Minor
file-based-router Minor
use-loader Minor
select-mul-entry-test Minor
select-one-entry-test Minor
server-config Minor
server-middleware Minor
server-new-middleware Minor
server-hook-reqeust Minor
server-hook-response Minor
server-hook-router Minor
@integration-test/server-hook-reqeust Minor
server-prod Minor
server-routes Minor
@source-code-build/app-ts-loader Minor
@source-code-build/app Minor
ssg-fixtures-nested-routes Minor
ssg-fixtures-simple Minor
ssg-fixtures-web-server Minor
ssr-base-json-test Minor
ssr-base-test Minor
ssr-base-fallback-test Minor
init Minor
ssr-inline Minor
ssr-preload Minor
ssr-script-loading Minor
ssr-streaming-test Minor
swc-test-decorator-legacy Minor
swc-test-decorator Minor
swc-minify-css Minor
swc-minify-js Minor
transform-fail Minor
integration-tailwindcss-v2 Minor
integration-tailwindcss-v3-js-config Minor
integration-tailwindcss-v3-merge-config Minor
integration-tailwindcss-v3-ts-config Minor
integration-tailwindcss-v3 Minor
twin-macro-v2 Minor
twin-macro-v3 Minor
tmp-dir Minor
@e2e/testing-plugin Minor
transform-import-type-test Minor
write-to-dist Minor
@e2e/garfish-dashboard-router-v6 Minor
@e2e/garfish-dashboard Minor
@e2e/garfish-main-router-v6 Minor
@e2e/garfish-main Minor
@e2e/garfish-table Minor
@modern-js/plugin-data-loader Minor
@modern-js/prod-server Minor
@modern-js/server Minor
@modern-js/server-utils Minor
@modern-js/uni-builder Minor
@modern-js/plugin-testing Minor
@modern-js/core Minor
@modern-js/storybook-builder Minor
@e2e/builder Minor
@modern-js/storybook Minor
integration-tests-storybook Minor
@modern-js/doc-plugin-auto-sidebar Minor
@modern-js/plugin-changeset Minor
@modern-js/plugin-i18n Minor
@modern-js/plugin-lint Minor
@modern-js/plugin-proxy Minor
@modern-js/rsbuild-plugin-esbuild Minor
@modern-js/builder-doc Minor
@modern-js/main-doc Minor
@modern-js/module-tools-docs Minor
@modern-js/new-action Minor
@modern-js/sandpack-react Minor
@modern-js-app/eslint-config Minor
@modern-js/eslint-config Minor
@modern-js/tsconfig Minor
@modern-js/babel-plugin-module-resolver Minor
@modern-js/bff-core Minor
@modern-js/bff-runtime Minor
@modern-js/create-request Minor
@modern-js/plugin-module-babel Minor
@modern-js/plugin-module-banner Minor
@modern-js/plugin-module-import Minor
@modern-js/plugin-module-node-polyfill Minor
@modern-js/plugin-module-polyfill Minor
@modern-js/plugin-module-vue Minor
@modern-js/module-tools Minor
@modern-js/monorepo-tools Minor
@modern-js/create Minor
@modern-js/e2e Minor
@modern-js/node-bundle-require Minor
@modern-js/plugin Minor
@modern-js/runtime-utils Minor
@modern-js/types Minor
@modern-js/upgrade Minor
@modern-js/utils Minor
@modern-js/babel-compiler Minor
@scripts/build Minor
@scripts/check-changeset Minor
@scripts/jest-config Minor
@scripts/lint-package-json Minor
@scripts/prebundle Minor
@scripts/update-codesmith Minor
@scripts/update-rsbuild Minor
@scripts/update-rspress Minor
@scripts/vitest-config Minor
esbuild-integration Minor
integration-load-config Minor
alias-js-test Minor
alias-ts-test Minor
asset-limit-test Minor
asset-name-test Minor
asset-path-test Minor
asset-publicPath-test Minor
svgr-test Minor
auto-extension-commonjs-test Minor
auto-extension-type-module-test Minor
auto-external-test Minor
banner-footer-test Minor
build-type-test Minor
copy-test Minor
decorator-test Minor
global-vars-js-test Minor
global-vars-ts-test Minor
dts-composite Minor
dts-test Minor
esbuild-options-test Minor
external-test Minor
format-cjs-test Minor
format-esm-test Minor
format-iife-test Minor
format-umd-test Minor
entry-test Minor
jsx-test Minor
metafile-test Minor
minify-test Minor
platform-test Minor
redirect-test Minor
data-url-test Minor
browser-false Minor
resolve-false Minor
ndoe-protocol-test Minor
lib1 Minor
lib2 Minor
lib3 Minor
condition-exports-test Minor
js-extensions-test Minor
main-fields-test Minor
shims-test Minor
module-tools-side-effects-test Minor
source-dir-test Minor
sourcemap-test Minor
splitting-test Minor
css-test Minor
less-test Minor
style-test Minor
postcss-test Minor
sass-test Minor
tailwindcss-test Minor
target-test Minor
transform-import Minor
transform-lodash Minor
tsconfig-test Minor
tsconfig-extends-test Minor
umdGlobals-test Minor
get-module-id-test Minor
dev-test Minor
build-platform-test Minor
build-preset-error-test Minor
build-preset-function-test Minor
build-preset-test Minor
build-preset-string-test Minor
integration-module-tools Minor
plugin-babel Minor
module-hooks-test Minor
plugin-node-polyfill Minor
plugin-polyfill Minor
plugin-vue Minor
runtime Minor
entry Minor
@source-code-build/common Minor
@source-code-build/components Minor
@source-code-build/utils Minor
ssg Minor
ssr Minor
swc-integration Minor
tailwindcss-integration-test Minor
@e2e/webpack-builder-import-antd-v4 Minor
@e2e/webpack-builder-import-antd-v5 Minor
@e2e/webpack-builder-import-arco Minor
@e2e/webpack-builder-test-moment Minor
@e2e/builder-remove-prop-types Minor
@e2e/webpack-builder-source-map Minor
@e2e/garfish Minor
@modern-js/generator-common Patch
@modern-js/generator-plugin Patch
@modern-js/generator-utils Patch
@modern-js/bff-generator Patch
@modern-js/dependence-generator Patch
@modern-js/entry-generator Patch
@modern-js/generator-generator Patch
@modern-js/module-doc-generator Patch
@modern-js/module-generator Patch
@modern-js/module-test-generator Patch
@modern-js/monorepo-generator Patch
@modern-js/mwa-generator Patch
@modern-js/router-v5-generator Patch
@modern-js/ssg-generator Patch
@modern-js/storybook-next-generator Patch
@modern-js/test-generator Patch
@modern-js/upgrade-generator Patch
@modern-js/generator-plugin-plugin Patch
@modern-js/base-generator Patch
@modern-js/changeset-generator Patch
@modern-js/packages-generator Patch
@modern-js/repo-generator Patch
@modern-js/server-generator Patch
@modern-js/tailwindcss-generator Patch
@modern-js/generator-cases Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@yimingjfe yimingjfe force-pushed the feat-deploy branch 4 times, most recently from 64f126c to 35e4240 Compare May 16, 2024 11:02
@zllkjc
Copy link
Member

zllkjc commented May 22, 2024

!canary

@GiveMe-A-Name
Copy link
Member

LGTM

@zllkjc
Copy link
Member

zllkjc commented May 23, 2024

img_v3_02b5_36d3e239-7f9b-4a31-9517-65f43d407feg
can we give a better ui for this...at least use ipv4 ?

@zllkjc
Copy link
Member

zllkjc commented May 23, 2024

add some docs impove in yimingjfe#1 @yimingjfe ~

@yimingjfe
Copy link
Member Author

yimingjfe commented May 23, 2024

img_v3_02b5_36d3e239-7f9b-4a31-9517-65f43d407feg can we give a better ui for this...at least use ipv4 ?

This is the server in the production environment, we should support dual stack and I think the address of ipv6 can be exposed. because It is clear, and other frameworks do the same.

@zllkjc
Copy link
Member

zllkjc commented May 24, 2024

This is the server in the production environment, we should support dual stack and I think the address of ipv6 can be exposed. because It is clear, and other frameworks do the same.

Ok, whether it is necessary to give the user an accessible ipv4 address here..if user start in local, then he can just click the url and preview the page.

@yimingjfe
Copy link
Member Author

yimingjfe commented May 24, 2024

This is the server in the production environment, we should support dual stack and I think the address of ipv6 can be exposed. because It is clear, and other frameworks do the same.

Ok, whether it is necessary to give the user an accessible ipv4 address here..if user start in local, then he can just click the url and preview the page.

This address can accept both ipv6 and ipv4 connections, including localhost, 127.0.0.1

Do you think it inappropriate to display [::]? I'm guessing it might be a matter of habit? We could listen to [::] and show the ipv4 address, but I don't think that's clear

@yimingjfe yimingjfe enabled auto-merge (squash) May 27, 2024 03:38
@yimingjfe yimingjfe merged commit 9d4d04d into web-infra-dev:main May 27, 2024
8 checks passed
@caohuilin caohuilin mentioned this pull request May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants