-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add Include/Exclude Class regular expression matcher #4937
base: main
Are you sure you want to change the base?
Conversation
1383e75
to
a2777ec
Compare
a2777ec
to
95477d9
Compare
Signed-off-by: Ying WANG <ying.wang@grafana.com>
95477d9
to
f0115b4
Compare
💵 To receive payouts, sign up on Algora, link your Github account and connect with Stripe/Alipay. |
Signed-off-by: Ying WANG <ying.wang@grafana.com>
819a4cb
to
db778ef
Compare
Quality Gate failedFailed conditions |
|
||
# Target to format code using gofumpt | ||
.PHONY: install-gofumpt format | ||
format: install-gofumpt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add make format and make generate-code, I used them to fix CI.
After running make generate-code, sonar failed for duplication, i think we should exclude certain folder from duplication check. I am not very familiar with sonar code analysis config. |
What's being changed:
/claim #2481
Never used bounty before, just for fun, thank you for building this nice project.
This PR aims to address issue #2481.
I think it is just a bad idea trying to guess whether users intend to use an exact match or a regular expression. So in order to distinguish the intention and give more flexibility on settings, whether we could change
include
list to a list of struct:This approach offers clarity in distinguishing between exact matches and regular expressions. However, it may increase verbosity.
or adding a new array:
{ "include_patterns": []{} }
This alternative maintains backward compatibility with existing APIs and reduces verbosity. This PR use the second approach, if the direction seems ok, i would update docs and examples accordingly, please let me know.
Review checklist