Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update packages to require Node 18 #7157

Merged
merged 6 commits into from
May 21, 2024
Merged

Update packages to require Node 18 #7157

merged 6 commits into from
May 21, 2024

Conversation

sethidden
Copy link
Contributor

@sethidden sethidden commented May 16, 2024

Upgrades all packages to require node 18

This also moves the storefronts packages that required Node 18 but were previously in a separate workspace

@sethidden sethidden requested a review from a team as a code owner May 16, 2024 11:51
Copy link

changeset-bot bot commented May 16, 2024

🦋 Changeset detected

Latest commit: 9327bb5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages
Name Type
@vue-storefront/integrations-tsconfig Major
@vue-storefront/api-extractor-config Major
@vue-storefront/eslint-config-integrations Major
@vue-storefront/prettier-config Major
@vue-storefront/eslint-config Major
@vue-storefront/rollup-config Major
@vue-storefront/sdk-axios-request-sender Major
@vue-storefront/jest-config Major
@vue-storefront/changesets Major
@vue-storefront/middleware Major
@vue-storefront/multistore Major
@vue-storefront/cli Major
@vue-storefront/sdk Major
@vue-storefront/next Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sethidden sethidden force-pushed the update-node-18 branch 4 times, most recently from 18e02f8 to 977a469 Compare May 16, 2024 12:06
"@vue-storefront/middleware": major
"@vue-storefront/multistore": major
"@vue-storefront/cli": major
"@vue-storefront/sdk": major
Copy link
Contributor Author

@sethidden sethidden May 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest SDK's major was 2.0.0 released on May 13 2024, so just 4 days ago. It's past the unpublish window so we'd have to e-mail NPM, or I could just release 3.0.0

@sethidden
Copy link
Contributor Author

The license problem apparent in CI is because of nuxt/nuxt#27233 - guess we can wait till Nuxt 3.12

Copy link
Collaborator

@WojtekTheWebDev WojtekTheWebDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing

@sethidden sethidden merged commit f06df9b into main May 21, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants