-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update packages to require Node 18 #7157
Conversation
🦋 Changeset detectedLatest commit: 9327bb5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
18e02f8
to
977a469
Compare
"@vue-storefront/middleware": major | ||
"@vue-storefront/multistore": major | ||
"@vue-storefront/cli": major | ||
"@vue-storefront/sdk": major |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest SDK's major was 2.0.0 released on May 13 2024, so just 4 days ago. It's past the unpublish window so we'd have to e-mail NPM, or I could just release 3.0.0
The license problem apparent in CI is because of nuxt/nuxt#27233 - guess we can wait till Nuxt 3.12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is failing
This installs @nuxt/ui-templates 1.3.4 which is MIT licensed (not CC-BY-ND-4.0)
Upgrades all packages to require node 18
This also moves the storefronts packages that required Node 18 but were previously in a separate workspace