Fix rendering anchor ref IDs (heading IDs) (#565) #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix vsch#545, do not escape special characters in `<pre><code>` block
Fix vsch#548: Converting html images fails if the image refers to an emoji without a shortcut
* Stop creating HTML ID generator if generateHeaderId = false (and renderHeaderID = true) * Ensure header ID is not empty
* Avoid duplicated setLastNode(..) call The call was happening first irrespective of whether the node was a TextContainer so lifted this logic out of the `if` block. * Avoid duplicate LineBreakNode logic It seems that currently LineBreakNode is independant of TextContainer so it seems safe to pull that out of the `if` block. * Paragraph with trailing blank line collects trailing blank line Consequently only a single new line is needed to add paragraph breaks * Collect a blank line before all (except first) Block instances - Removed special case logic for Paragraph blocks - Generalised from BlankLineBreakNode case * IndentedCodeBlock implements TextContainer Implementation based on Text collectText(..) but using getContentChars()
…ibutes with IDs) (vsch#565)
|
Hi @vsch, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think, I fixed the bug described in discussion #565.
There's only one question left: The test suite
ExtAttributesTestSuitefails in the case "example(Anchor Targets - Cond 4.1: 3) options(anchors)", see comparison of expected and actual output. Shouldn't the id in this case only be placed in the h1 tag?