Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Add page for PoolingParams #4800

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

DarkLight1337
Copy link
Collaborator

@DarkLight1337 DarkLight1337 commented May 14, 2024

This PR builds on #4710 by adding a page for PoolingParams which was recently introduced by #3734.

@DarkLight1337
Copy link
Collaborator Author

DarkLight1337 commented May 14, 2024

@CatherineSue Currently, the purpose of PoolingParams is unclear since it has no required arguments. More detailed docs for PoolingParams would be greatly appreciated!

@robertgshaw2-neuralmagic
Copy link
Collaborator

@CatherineSue Currently, the purpose of PoolingParams is unclear since it has no required arguments. More detailed docs for PoolingParams would be greatly appreciated!

Right now PoolingParams is a stub - will be used to support different pooling strategies.

We are about to open an RFC for further work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants