[mediaplayer] Use playerctl's streaming output support, dropping non-MPRIS #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hseg
changed the title
hseg
changed the title
As clarified in vivien#499, this is less of a problem than it appears, since the players dropped support MPRISv2 - some natively, some with a builtin plugin that needs to be enabled, and some with a well-supported plugin Closes: vivien#499
Ignores artist if absent (the hack of giving a control character default and stripping it is unfortunately necessary at the moment, cf altdesktop/playerctl#296) Closes: vivien#498
Ignores artist if absent (the hack of giving a control character default and stripping it is unfortunately necessary at the moment, cf altdesktop/playerctl#296) Closes: vivien#498
hseg
force-pushed
the
mediaplayer-mpris-wishlist
branch
from
ad86182
to
8e9e780
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a version of #500 that includes the non-MPRIS codepath dropping of #501.
In addition, having dropped these codepaths, we can now make use of
playerctl -F, which allows the metadata notifications to be pushed byplayerctlinstead of polled byi3blocks.Closes: #498, #498, #500, #501