Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mediaplayer] no output if metadata invalid #498

Open
hseg opened this issue Aug 28, 2023 · 0 comments · May be fixed by #500 or #502
Open

[mediaplayer] no output if metadata invalid #498

hseg opened this issue Aug 28, 2023 · 0 comments · May be fixed by #500 or #502

Comments

@hseg
Copy link
Contributor

hseg commented Aug 28, 2023

With mpv (which exercises the playerctl codepath), when playing media which only has valid title tags (but no valid artist), the blocklet crashes without output.
(It works perfectly fine if both are defined for the file)
Instead, a best-effort attempt would replace the artist name by a placeholder or ignore it.
hseg added a commit to hseg/i3blocks-contrib that referenced this issue Aug 28, 2023
@hseg
[mediaplayer] use playerctl's formatting support
8460a79 
Ignores artist if absent (the hack of giving a control character default
and stripping it is unfortunately necessary at the moment, cf
altdesktop/playerctl#296)

Closes: vivien#498
This was referenced Aug 28, 2023
Open
Open
hseg added a commit to hseg/i3blocks-contrib that referenced this issue Feb 11, 2024
@hseg
[mediaplayer] use playerctl's formatting support
900448b 
Ignores artist if absent (the hack of giving a control character default
and stripping it is unfortunately necessary at the moment, cf
altdesktop/playerctl#296)

Closes: vivien#498
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@hseg