asyncBoot will no longer try booting server again if it is already booted

[RussBaz]

These changes are now available in 4.100.2

The synchronous boot function skips running the lifecycle handlers if the server is already booted. However, the async version ignored this check. I have added a small fix to add this check again.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.46%. Comparing base (11cdb29) to head (6e83023).
Report is 24 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3195      +/-   ##
==========================================
+ Coverage   76.86%   77.46%   +0.59%     
==========================================
  Files         211      210       -1     
  Lines        8119     8089      -30     
==========================================
+ Hits         6241     6266      +25     
+ Misses       1878     1823      -55     

Files	Coverage Δ
Sources/Vapor/Application.swift	84.30% <100.00%> (-3.56%)	⬇️

... and 94 files with indirect coverage changes

[0xTim]

Thanks! Could you add a test to ensure this works?

    func testBootDoesNotTriggerHandlerMultipleTimes() throws {
        let app = Application(.testing)
        defer { app.shutdown() }
        
        final class Handler: LifecycleHandler, Sendable {
            let bootCount = NIOLockedValueBox(0)
            func willBoot(_ application: Application) throws {
                bootCount.withLockedValue { $0 += 1 }
            }
        }
        
        let handler = Handler()
        app.lifecycle.use(handler)
        
        try app.boot()
        try app.boot()

        XCTAssertEqual(handler.bootCount.withLockedValue({ $0 }), 1)
    }
    
    func testAsyncBootDoesNotTriggerHandlerMultipleTimes() async throws {
        let app = try await Application.make(.testing)
        
        final class Handler: LifecycleHandler, Sendable {
            let bootCount = NIOLockedValueBox(0)
            func willBoot(_ application: Application) throws {
                bootCount.withLockedValue { $0 += 1 }
            }
        }
        
        let handler = Handler()
        app.lifecycle.use(handler)
        
        try await app.asyncBoot()
        try await app.asyncBoot()

        XCTAssertEqual(handler.bootCount.withLockedValue({ $0 }), 1)
        
        try await app.asyncShutdown()
    }

In ApplicationTests should work

[RussBaz]

Done. Please have a look again.

[0xTim]

Thanks!