-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix decoding 'flag' URL query params via .decode(StructType.self)
#3164
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@gwynne any thoughts?
@challfry could you fix the conflicts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm okay with it, once the conflicts are fixed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3164 +/- ##
==========================================
+ Coverage 76.86% 77.63% +0.76%
==========================================
Files 211 210 -1
Lines 8119 8137 +18
==========================================
+ Hits 6241 6317 +76
+ Misses 1878 1820 -58
|
Merge conflicts fixed. For the failing vapor/jwt test, it appears jwt-kit changed part of their API last week, and jwt's JWTTests.swift is yet to be updated. |
These changes are now available in 4.101.3
Fixes #3163.
The code:
produces
queryStruct.flag1 == true
when decoding the URL query "?flag1", matching the behavior ofreq.query[Bool.self, at: "flag1"]
.