Sample Helm chart #63
Conversation
|
Hey @jseiser thank you for this clean Helm chart! I deployed my Vigil release using it, but somehow the vigil pod keeps restarting like every ~30 minutes. Would you have any idea why it behaves this way? Thank you! |
|
This is really useful. Please, merge it or create a dedicated project for it (with link from vigil project) |
| metadata: | ||
| {{- with .Values.podAnnotations }} | ||
| annotations: | ||
| checksum/config: {{ include (print $.Template.BasePath "/secrets.yaml") . | sha256sum }} |
There was a problem hiding this comment.
there's no secrets.yaml therefore no reason to restart the Pod if this file updates
| - name: vigil | ||
| configMap: | ||
| name: {{ include "vigil.fullname" . }} | ||
| defaultMode: 0777 |
There was a problem hiding this comment.
the app doesn't need to write anything there, it's just pointing to the configuration file therefore this mode is redundant in this case
| {{- if semverCompare ">=1.14-0" .Capabilities.KubeVersion.GitVersion -}} | ||
| apiVersion: networking.k8s.io/v1beta1 | ||
| {{- else -}} | ||
| apiVersion: extensions/v1beta1 |
There was a problem hiding this comment.
This will not be compatible with Kubernetes v1.19+ which uses
apiVersion: networking.k8s.io/v1
https://kubernetes.io/docs/concepts/services-networking/ingress/
| logo_url = "{{ .Values.vigil.logo_url }}" | ||
| website_url = "{{ .Values.vigil.website_url }}" | ||
| support_url = "{{ .Values.vigil.support_url }}" | ||
| custom_html = "{{ .Values.vigil.customer_html }}" |
There was a problem hiding this comment.
probably default these to the sample config.cfg that we have in this repo so that at least the app boots properly & healthiness/readiness probes pass. Default only if not overridden.
At least the user will be able to port-forward to the service and see if the status page is working & how it looks initially (as a demo).
it's enough to get you started, just install it and do a port-forward to :8080 and you'll have a demo status page at your disposal Resolves: valeriansaliou#63 Related: Signed-off-by: Daniel-Andrei Minca <mandrei17@gmail.com>
I wouldn't merge this, but if you wanted to create a helm chart repo, and use something like github pages to publish it, its a working chart that I am using myself.