-
Notifications
You must be signed in to change notification settings - Fork 838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added support for IPv6 in GitHub Actions #904
base: master
Are you sure you want to change the base?
Conversation
Recently we submitted a PR for adding `ipv6: true` to the yaml config to check IPv6. However GitHub actions does not yet support IPv6 unfortunately. This PR is necessary as it uses Cloudflare WARP network configuration on the runner to add IPv6 support. See <actions/runner-images#668 (comment)> for more insight.
We can't update the workflows directly like this because they are generated in the code, but I'll added this feature here: upptime/uptime-monitor@e328be7. Please let me know if it works for you! How I've set it up is that we detect whether there's any site with |
Thank you, testing this out now. |
This reverts commit 0f696ce.
I don't think this is working @AnandChowdhary, I don't think it has any affect on "Uptime CI" job yet, which it should? https://github.com/forwardemail/status.forwardemail.net/actions/runs/7451369909/workflow You can see our IPv6 checks are failing still at https://status.forwardemail.net |
Yep, error in syntax here @AnandChowdhary https://github.com/forwardemail/status.forwardemail.net/actions/runs/7451497444/workflow |
This reverts commit 473c738.
On it! |
Should be fixed in https://github.com/upptime/uptime-monitor/releases/tag/v1.36.1 :D |
Thank you 🙏 will test |
…is merged"" This reverts commit 1511162.
@AnandChowdhary this is still unfortunately not working, as it seems the conditional might be an issue? |
… is merged"" This reverts commit 66f3fbb.
@AnandChowdhary can you please simply just merge this PR instead of all the other work you're doing with custom yaml file generation? This is way more reliable for DNS checking anyways, as Cloudflare is way more reliable to use than whatever the default is for GitHub CI. |
Hey @titanism, sorry for the delay here, I understand that it's annoying for it to not work and for you to have to wait. The problem is that if we make any changes to the workflow here, like in your PR, they will be automatically overwritten when the next update happens, for example here -- forwardemail/status.forwardemail.net@275501d. So even if we want to remove the conditional and add this step to all workflows, it still needs to be added to the codebase in the I just tested it and "Update Template" ran as expected and made this commit 50520e9 after my commit adding your site in 5a830c4. But even after adding that step, the next run marks your site as down - https://github.com/upptime/upptime/actions/runs/7527414163/job/20487519591. Are you certain that adding this step should make it work? |
Interesting, |
Can you please run "Update Template CI" manually, and then when it's done run "Setup CI"? Let' see if it works :) |
Recently we submitted a PR for adding
ipv6: true
to the yaml config to check IPv6. However GitHub actions does not yet support IPv6 unfortunately. This PR is necessary as it uses Cloudflare WARP network configuration on the runner to add IPv6 support. See actions/runner-images#668 (comment) for more insight.