Add linux build that uses gcc #902
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@endoffile78 let's disable tests for now, and see what happens |
jhert0
force-pushed
the
travis-gcc
branch
4 times, most recently
from
c6c31a6
to
72e3bd5
Compare
GrayHatter
reviewed
Apr 16, 2019
There was a problem hiding this comment.
@endoffile78 close or merge?
Reviewable status: 7 files need 2 more reviewers, 1 assignee LGTMs are missing, missing Admin LGTM at current revision.
GrayHatter
approved these changes
Apr 16, 2019
There was a problem hiding this comment.
Reviewed 8 of 8 files at r1.
Reviewable status: 8 files need 1 more reviewer, 1 assignee LGTMs are missing, missing Admin LGTM at current revision.
src/ui/edit.c, line 750 at r1 (raw file):
char *p = edit->data + edit_sel.start; const size_t selection_size = edit->length - edit_sel.length + len;
FYI, I don't like this, but it's fine.
|
@endoffile78 all builds fail |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is