Make push-to-talk work at every X11 platform. #1328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrayHatter
reviewed
Feb 21, 2019
| static bool linux_check_ptt(void) { | ||
| #ifdef HAVE_EVDEV |
There was a problem hiding this comment.
I don't like inline ifdefs
Plus, it's not linux_check_ptt if it's running on bsd
There was a problem hiding this comment.
right, I forgot about renaming the function
GrayHatter
requested changes
Mar 8, 2019
src/xlib/main.c
Outdated
| /* First, we try for direct access to the keyboard. */ | ||
| if (ppt_keyboard_handle()) | ||
| return true; | ||
| else if (!ppt_keyboard_handle_unknown) |
jhert0
approved these changes
Mar 11, 2019
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1, 1 of 1 files at r3.
Reviewable status: 2 files need 1 more reviewer, 2 open discussions remaining, missing Admin LGTM at current revision.
|
@GrayHatter please remind me the link to branch, I can't find it. |
robinlinden
approved these changes
Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DragonFly BSD changed location for evdev input.h file, FreeBSD has different location from the beginning. Note that DragonFly BSD is compiled without evdev support by default, but it still has that header.
This change is