Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hint for language-region pair on text.lang #4183

Merged
merged 1 commit into from
May 25, 2024

Conversation

Coekjan
Copy link
Contributor

@Coekjan Coekjan commented May 18, 2024

This pr closes #4142 . If I get it correctly, text.lang is the only place parsing ISO language code.

I added a new function parse_lang to parse an argument for text.lang:

  1. Use Lang::from_str to parse the arg. If success, all done.
  2. Check whether the arg is a lang-region pair. If so, give a hint.

@Coekjan Coekjan force-pushed the text-lang-hint-region-field branch 2 times, most recently from 75b15c4 to e732be5 Compare May 18, 2024 08:42
@Coekjan Coekjan force-pushed the text-lang-hint-region-field branch from e732be5 to ff7424b Compare May 18, 2024 11:12
@Coekjan Coekjan force-pushed the text-lang-hint-region-field branch from 85b6964 to 73decc3 Compare May 23, 2024 03:56
@Coekjan Coekjan requested a review from laurmaedje May 23, 2024 12:02
@laurmaedje laurmaedje added this pull request to the merge queue May 25, 2024
@laurmaedje
Copy link
Member

Thanks!

Merged via the queue into typst:main with commit 485aa2e May 25, 2024
6 checks passed
@Coekjan Coekjan deleted the text-lang-hint-region-field branch May 26, 2024 05:35
Enter-tainer pushed a commit to Enter-tainer/typst that referenced this pull request May 26, 2024
PgBiel added a commit to tulio240/typst that referenced this pull request May 30, 2024
Refactor frame metadata into tags (typst#4212)


Require `Send` and `Sync` for worlds (typst#4219)


Optimize counters and state (typst#4223)


Add `windows` method to array (typst#4136)

Improve `CITATION.cff` file (typst#4201)


Fix equation resizing when adding the equation number (typst#4179)


`layout` documentation improvements (typst#4196)

Allow somewhat arbitrary characters as `mat`, `vec` and `cases` `delim` (typst#4211)


Do layout short-circuit in flow instead of realization (typst#4231)


Split `BitSet` into two types and make it a bit nicer (typst#4249)


Set default value of `raw.theme` to `auto`, and allow setting `raw.theme` to `auto` (typst#4186)


Extended cargo installation instructions (typst#4168)

Hint for language-region pair on `text.lang` (typst#4183)


Improve macro docs (+ Native*Data docs) (typst#4240)


Rephrase the sentence on variable scope in Scripting documentation (typst#4250)


Refactor `Capable::vtable` to return `Option<NonNull<()>>` (typst#4252)


Nicer test helper CSS (typst#4269)


Trim weak spacing at line start/end in paragraph layout (typst#4087)


Add ability to choose between minified and pretty-printed JSON (typst#4161)


Refactor PDF export (typst#4154)

Reorder syntax kinds (typst#4287)


Fix figure centering (typst#4276)

Fix `Default` impls for AST nodes (typst#4288)


Bump libc to v0.2.155 (typst#4268)


Bump time dependency (typst#4294)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hint for language-region pair where language is expected
4 participants