Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update auth-guard.md: intro text for custom claims and TTL #2110

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

JorisDebonnet
Copy link

@JorisDebonnet JorisDebonnet commented Apr 2, 2021

I added two introductory texts for two items I had some difficulty with myself, just getting started with this:

  1. The "custom claims" mentioned here are only for general claims, not for user-specific claims. I was wondering, but where do I put the user-specific ones then? So I added that information.
  2. The TTL example seemed very misleading. The default TTL is 1 hour, which displays as 3600 seconds in the default 'expires_in' response field. So people new to this will probably associate the number 7200 with 2 hours. But setTTL sets it in minutes, not seconds. 7200 minutes translates to 5 days, which I guess is possible, but not intuitive, so I changed it and clarified that we're talking about minutes here.

@JorisDebonnet JorisDebonnet changed the title Intro text for custom claims and TTL Update auth-guard.md: intro text for custom claims and TTL Apr 2, 2021
@JorisDebonnet
Copy link
Author

(In all honesty, I find it very counter-intuitive that TTL is used in minutes in this package. I would highly recommend changing it to seconds in some future 2.x version.)

@eschricker
Copy link

Hi @JorisDebonnet ,
due to the inactivity of the project, we have forked the repository (https://github.com/PHP-Open-Source-Saver/jwt-auth). Currently we are going through the PR and identify which are relevant for us. It would be great if you would recreate your PR in our repository.

@JorisDebonnet
Copy link
Author

Hi @JorisDebonnet ,
due to the inactivity of the project, we have forked the repository (https://github.com/PHP-Open-Source-Saver/jwt-auth). Currently we are going through the PR and identify which are relevant for us. It would be great if you would recreate your PR in our repository.

Hello, nice initiative! However, I am not actually using this package anymore. I moved to using laravel/passport for my API, instead of lumen with this). So feel free to recreate the changes from this PR into your fork.

@eschricker
Copy link

Great, thank you for your fast reply. I will recreate the PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants