Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unimplement deprecated fastutil method #22031

Merged
merged 1 commit into from
May 21, 2024
Merged

Conversation

wendigo
Copy link
Contributor

@wendigo wendigo commented May 20, 2024

It's implemented by the interface:

@Deprecated
@Override
default int compare(Integer ok1, Integer ok2) {
    return compare(ok1.intValue(), ok2.intValue());
}

@findepi
Copy link
Member

findepi commented May 20, 2024

It's implemented by the interface:

@Deprecated
@Override
default int compare(Integer ok1, Integer ok2) {
    return compare(ok1.intValue(), ok2.intValue());
}

good explanation. let's add this to the commit message

It's implemented by the interface:

@deprecated
@OverRide
default int compare(Integer ok1, Integer ok2) {
    return compare(ok1.intValue(), ok2.intValue());
}
@wendigo wendigo force-pushed the serafin/remove-deprecated-usage branch from f2637e7 to 6851970 Compare May 21, 2024 07:46
@wendigo
Copy link
Contributor Author

wendigo commented May 21, 2024

Just amended commit message.

@wendigo wendigo merged commit 9154780 into master May 21, 2024
2 of 13 checks passed
@wendigo wendigo deleted the serafin/remove-deprecated-usage branch May 21, 2024 07:47
@github-actions github-actions bot added this to the 449 milestone May 21, 2024
@colebow colebow added the no-release-notes This pull request does not require release notes entry label May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed no-release-notes This pull request does not require release notes entry
Development

Successfully merging this pull request may close these issues.

None yet

3 participants