Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Support for environmental substitution in config.json #117

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

arulrajnet
Copy link

@arulrajnet arulrajnet commented Nov 13, 2022

This PR has

  • support for environmental substitution in config.json using python Template. Refer comment in File/environment-based secrets #35
  • Allow to run the scripts from root/any folder. For ex ./scripts/docker-build.sh

@arulrajnet
Copy link
Author

@timothymiller Is there anything I am missing to merge this PR?

@arulrajnet
Copy link
Author

@timothymiller do you actively maintain this project?

Seems no PR merged after Aug 2022

@andrp92
Copy link

andrp92 commented Feb 9, 2023

👀

@timothymiller
Copy link
Owner

┻━┻︵ (°□°)/ ︵ ┻━┻
Merging PRs tomorrow

@timothymiller timothymiller changed the title support for environmental substitution in config.json [feature] Support for environmental substitution in config.json Feb 15, 2023
@timothymiller
Copy link
Owner

Very cool @arulrajnet! Can you update this PR so the feature works as an either or.

Example: If environment variables are defined, then skip parsing config.json

I'd like to keep backwards compatibility for users of the existing config.json method.

@timothymiller
Copy link
Owner

I merged a few other PRs, one that added support for extracting IP from the network interface, instead of an HTTP request to Cloudflare. Would you mind syncing up with the master branch?

@arulrajnet
Copy link
Author

@timothymiller Addressed all the comments.

  • skip parsing config.json if the environment variables are defined
  • Sync with master.

@arulrajnet
Copy link
Author

@timothymiller could you review again?

@yorickdowne
Copy link

This is a pretty big deal for me, this'd allow me to not bind-mount config.json, and instead do all config via env variables.

A second PR could have a default config.json that can be overridden via bind mount.

@shaunbharat
Copy link

This is a pretty big deal for me, this'd allow me to not bind-mount config.json, and instead do all config via env variables.

A second PR could have a default config.json that can be overridden via bind mount.

Environment variables would also simplify things in my situation.

@timothymiller, I wanted to bring your attention back to this PR because it would be beneficial to my current home lab configuration. Is there any update on if/when this PR can be merged? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants