New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Support for environmental substitution in config.json #117
base: master
Are you sure you want to change the base?
Conversation
…mplate refer comment in timothymiller#35
@timothymiller Is there anything I am missing to merge this PR? |
@timothymiller do you actively maintain this project? Seems no PR merged after Aug 2022 |
👀 |
┻━┻︵ (°□°)/ ︵ ┻━┻ |
Very cool @arulrajnet! Can you update this PR so the feature works as an either or. Example: If environment variables are defined, then skip parsing I'd like to keep backwards compatibility for users of the existing |
I merged a few other PRs, one that added support for extracting IP from the network interface, instead of an HTTP request to Cloudflare. Would you mind syncing up with the master branch? |
@timothymiller Addressed all the comments.
|
@timothymiller could you review again? |
This is a pretty big deal for me, this'd allow me to not bind-mount config.json, and instead do all config via env variables. A second PR could have a default config.json that can be overridden via bind mount. |
Environment variables would also simplify things in my situation. @timothymiller, I wanted to bring your attention back to this PR because it would be beneficial to my current home lab configuration. Is there any update on if/when this PR can be merged? Thanks! |
This PR has
./scripts/docker-build.sh