Proxy: unify store filtering #7371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaHoffmann
force-pushed
the
mhoffm-proxy-store-unify-store-filtering
branch
from
96bf77c
to
d86bd0e
Compare
In LabelNames and LabelValues gRPC calls were not pruned properly. While results are not wrong, this leads to inefficient fan-out for setups with many endpoints. We took the opportunity to unify the store filtering and generally also the larger layout of the gRPC methods, including logging and tracing. Signed-off-by: Michael Hoffmann <mhoffm@posteo.de>
MichaHoffmann
force-pushed
the
mhoffm-proxy-store-unify-store-filtering
branch
from
d86bd0e
to
8f7e9ae
Compare
SuperQ
reviewed
May 21, 2024
| return &storepb.LabelValuesResponse{ | ||
| Values: strutil.MergeUnsortedSlices(all...), | ||
| Warnings: warnings, | ||
| }, nil | ||
| } | ||
|
|
||
| func storeInfo(st Client) (storeID string, storeAddr string, isLocalStore bool) { |
There was a problem hiding this comment.
Why not make this a struct function?
Suggested change
| func storeInfo(st Client) (storeID string, storeAddr string, isLocalStore bool) { | |
| func (st *Client) Info() (storeID string, storeAddr string, isLocalStore bool) { |
Also, I'm not a big fan of the use of multiple named returns like this. For example, I think it would be better to implement individual funcs like func (st *Client) IsLocalStore() bool {...}.
2 tasks
fpetkovski
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In LabelNames and LabelValues gRPC calls were not pruned properly. While results are not wrong, this leads to inefficient fan-out for setups with many endpoints.
We took the opportunity to unify the store filtering and generally also the larger layout of the gRPC methods, including logging and tracing.
Verification
Existing unittests.