compact: Add compactor time validation #7293
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds validation to
--min-time
and--max-time
flags. The documentation isn't super clear and caused me confusion, along with another report in this issueAs far as I'm able to reason about
--min-time
durations in the future are nonsensical and invalid, but future absolute times are valid.--min-time
should never be a more recent date than--max-time
.Verification
Invalid use cases caught by new validation
Future time for
--min-time
--max-time
greater than--min-time
Existing, valid use cases still passing
No time ranges
Only
--min-time
specifiedFuture absolute time specified for
--min-time