Merge upstream tag '4.19.1'

release i3-gaps 4.19.1

I3_VERSION

@@ -0,0 +1 @@
+4.19.1-non-git

RELEASE-NOTES-4.19.1

@@ -0,0 +1,27 @@
+
+ ┌──────────────────────────────┐
+ │ Release notes for i3 v4.19.1 │
+ └──────────────────────────────┘
+
+This is i3 v4.19. This version is considered stable. All users of i3 are
+strongly encouraged to upgrade.
+
+This is a bugfix release for v4.19
+
+ ┌────────────────────────────┐
+ │ Bugfixes                   │
+ └────────────────────────────┘
+
+  • fix workspaces not moving to assigned output after output becomes available
+  • fix duplicate bindcode after i3-config-wizard
+  • fix commented-out rofi call in default i3 config
+
+ ┌────────────────────────────┐
+ │ Thanks!                    │
+ └────────────────────────────┘
+
+Thanks for testing, bugfixes, discussions and everything I forgot go out to:
+
+  Anaël Beutot, Imran Virani, Orestis Floros
+
+-- Michael Stapelberg, 2021-02-01

etc/config

@@ -54,7 +54,7 @@ bindsym Mod1+Shift+q kill
 # start dmenu (a program launcher)
 bindsym Mod1+d exec --no-startup-id dmenu_run
 # A more modern dmenu replacement is rofi:
-# bindsym Mod1+d exec rofi -modi drun,run -show drun
+# bindsym Mod1+d exec "rofi -modi drun,run -show drun"
 # There also is i3-dmenu-desktop which only displays applications shipping a
 # .desktop file. It is a wrapper around dmenu, so you need that installed.
 # bindsym Mod1+d exec --no-startup-id i3-dmenu-desktop

etc/config.keycodes

@@ -48,10 +48,10 @@ bindcode $mod+Shift+24 kill
 # start dmenu (a program launcher)
 bindcode $mod+40 exec --no-startup-id dmenu_run
 # A more modern dmenu replacement is rofi:
-# bindcode $mod+40 exec rofi -modi drun,run -show drun
+# bindcode $mod+40 exec "rofi -modi drun,run -show drun"
 # There also is i3-dmenu-desktop which only displays applications shipping a
 # .desktop file. It is a wrapper around dmenu, so you need that installed.
-bindcode $mod+40 exec --no-startup-id i3-dmenu-desktop
+# bindcode $mod+40 exec --no-startup-id i3-dmenu-desktop
 
 # change focus
 bindcode $mod+44 focus left

meson.build

@@ -6,7 +6,7 @@
 project(
   'i3',
   'c',
-  version: '4.19',
+    version: '4.19.1',
   default_options: [
     'c_std=c11',
     'warning_level=1',  # enable all warnings (-Wall)
@@ -63,7 +63,7 @@ config_h = declare_dependency(
   sources: vcs_tag(
     input: config_h_in,
     output: 'config.h',
-    fallback: meson.project_version() + ' (2020-11-15)',
+    fallback: meson.project_version() + ' (2021-02-01)',
   )
 )
 

src/randr.c

@@ -439,28 +439,31 @@ void init_ws_for_output(Output *output) {
     Con *previous_focus = con_get_workspace(focused);
 
     /* Iterate over all workspaces and check if any of them should be assigned
-     * to this output. */
-    Con *output_con;
-    TAILQ_FOREACH (output_con, &(croot->nodes_head), nodes) {
-        if (con_is_internal(output_con)) {
+     * to this output.
+     * Note: in order to do that we iterate over all_cons and not using another
+     * list that would be updated during iteration by the
+     * workspace_move_to_output function. */
+    Con *workspace;
+    TAILQ_FOREACH (workspace, &all_cons, all_cons) {
+        if (workspace->type != CT_WORKSPACE || con_is_internal(workspace)) {
             continue;
         }
 
-        Con *workspace;
-        TAILQ_FOREACH (workspace, &(output_get_content(output_con)->nodes_head), nodes) {
-            Con *workspace_out = get_assigned_output(workspace->name, workspace->num);
-            if (output->con != workspace_out) {
-                continue;
-            }
+        Con *workspace_out = get_assigned_output(workspace->name, workspace->num);
 
-            DLOG("Moving workspace \"%s\" from output \"%s\" to \"%s\" due to assignment\n",
-                 workspace->name, workspace_out->name, output_primary_name(output));
-            /* Need to copy output's rect since content is not yet rendered. We
-             * can't call render_con here because render_output only proceeds
-             * if a workspace exists. */
-            content->rect = output->con->rect;
-            workspace_move_to_output(workspace, output);
+        if (output->con != workspace_out) {
+            continue;
         }
+
+        DLOG("Moving workspace \"%s\" from output \"%s\" to \"%s\" due to assignment\n",
+             workspace->name, output_primary_name(get_output_for_con(workspace)),
+             output_primary_name(output));
+
+        /* Need to copy output's rect since content is not yet rendered. We
+         * can't call render_con here because render_output only proceeds
+         * if a workspace exists. */
+        content->rect = output->con->rect;
+        workspace_move_to_output(workspace, output);
     }
 
     /* Temporarily set the focused container, might not be initialized yet. */