Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added icons for Substack and Threads #120

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

djscruggs
Copy link

I'm not an svg expert and had to do use transform=scale(xx) to make them fit.

Copy link
Owner

@tbakerx tbakerx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the very late review, thank you for the additions! Minor change request as per your note in the PR description:

To avoid the need to scale the icon with transform, the svgs that you are using should have a viewbox attribute declared. With a slight modification to the <Icon/> component, we can pass that viewbox as a prop and set it on the parent <svg/> tag (falling back to my hardcoded 0 0 128 128). Does this make sense?

@djscruggs
Copy link
Author

That sounds good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants