-
-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added native Progress and Select implementations #2234
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
if (props.native && isIos) { | ||
return <NativeSelect {...props} /> | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Likely can't do this naive approach. Will probably need a setup function since expo modules core is needed.
if (props.native && isIos) { | ||
return <NativeProgress {...props} /> | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Likely can't do this naive approach. Will probably need a setup function since expo modules core is needed.
I think we'd basically want to do it how we do Sheet now but even a bit further since we have the native package ourselves
|
b511df6
to
e467306
Compare
What changed?
To Do...
Progress
max
andvalue
props (I think it also supports all tamagui props but it applies it to the wrapper not the actual swiftui view... need to test this more)Screen.Recording.2024-03-04.at.9.16.42.AM.mov
Select
Select.Item
andSelect.ItemText
to pass value and label to the underlying native view.nativeType
prop to allow the user to select betweenwheel
andmenu
(defaults to menu). This can be removed if we want to start simple. Can also add support for a segmented picker, just wanted to start small.Screen.Recording.2024-03-04.at.9.42.25.AM.mov