tsweb: log once per request #12141
Open
tsweb: log once per request #12141
+338
−135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icio
force-pushed
the
icio/tsweb-nested-stdhandler
branch
3 times, most recently
from
c53e442
to
2cdec70
Compare
icio
commented
May 15, 2024
marwan-at-work
approved these changes
May 30, 2024
icio
force-pushed
the
icio/tsweb-nested-stdhandler
branch
from
2cdec70
to
798a6c0
Compare
|
I've rebased this following the addition on OnCompletion, which I think would also suffer from repeated calls when StdHandler is nested. Actually... I think this will have affected the StatusCodeCounters and BucketStats too... |
StdHandler/retHandler would previously emit one log line for each request. If there were multiple StdHandler in the chain, there would be one log line per instance of retHandler. With this change, only the outermost StdHandler/logHandler actually logs the request. The error-rendering part of retHandler lives on in errorHandler, and errorHandler passes those errors up the stack to logHandler through a callback that logHandler places in the request.Context(). Updates tailscale/corp#19999 Signed-off-by: Paul Scott <paul@tailscale.com>
icio
force-pushed
the
icio/tsweb-nested-stdhandler
branch
from
798a6c0
to
5003fa4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StdHandler/retHandler would previously emit one log line for each request. If there were multiple StdHandler in the chain, there would be one log line per instance of retHandler.
With this change, only the outermost StdHandler/logHandler actually logs the request. The error-rendering part of retHandler lives on in errorHandler, and errorHandler passes those errors up the stack to logHandler through a callback that logHandler places in the request.Context().
This change already yields the log changes desired in #19999 but we could then swap some StdHandler usage for LogHandler/Handler in various places.
Updates tailscale/corp#19999