chore: make experimental-dev example app #20327
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuaellis
added
source: tooling
|
I'm wondering if we should rename |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Size Change: -48 B (0%) Total Size: 2.53 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
We need a bit more discussion on this.
The current "getstarted" should really be called "kitchensink" since it's got almost everything in it
The current "kitchensink" should be called something like "empty" or "clean" or almost anything else.
And then there should be a -ts version of those.
Should it be called Do we need TS versions of both, couldn't we just use the TS versions on their own? I don't think anyone realistically tests against the JS/TS versions? 🤔 at most we could do a |
|
I'm also wondering, how temporary is this? Do we actually want to add something like this to main or would we be better off keeping a POC branch where we can QA against it until releasing it. |
|
It all makes sense to me. I guess this kind of error is caused by the React 19 DS compatibility issues you mentioned? |
yep! |
joshuaellis
force-pushed
the
chore/add-experimental-dev-application
branch
from
a86e32a
to
735634b
Compare
joshuaellis
force-pushed
the
chore/add-experimental-dev-application
branch
from
735634b
to
a802163
Compare
joshuaellis
changed the title
joshuaellis
force-pushed
the
chore/add-experimental-dev-application
branch
from
a802163
to
bad4f63
Compare
joshuaellis
force-pushed
the
chore/add-experimental-dev-application
branch
2 times, most recently
from
590f8ad
to
fef1c82
Compare
joshuaellis
force-pushed
the
chore/add-experimental-dev-application
branch
from
fef1c82
to
e02e60c
Compare
|
I agree with Ben we should have JS and TS versions as we support both and thus should test both. |
theres an RFC internally on this if you want to comment :) I think Ben shared it in engineering, the comments are out of date with what the PR does |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
experimental-devapplication set up to work with react-rc & the compilerUSE_EXPERIMENTAL_DEPENDENCIESflag to the strapi develop/build commands so we can test RCs / Betas of deps we require users to install in their strapi projectsWhy is it needed?
Related issue(s)/PR(s)